-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shapelib] Fix shapelib usage #22633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/shapelib/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
-# for the export_shp name. | ||
-install(EXPORT export_shp DESTINATION ${CMAKE_INSTALL_SHP_DATADIR}) | ||
+# for the shpConfig name. | ||
+install(EXPORT shpConfig DESTINATION ${CMAKE_INSTALL_SHP_DATADIR}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also please report this to the upstream plase.
Thanks for the fix! |
Describe the pull request
What does your PR fix?
Fixes [shapelib] Unable to find shp-config.cmake when including in build #16041Shapelib unable to find shp-config.cmake when including in build
Export the shpConfig file can solved the bug
I have test the usage successfully on my local machine: