Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fastcgi] Fix release-only build #22672

Merged
merged 1 commit into from
Jan 26, 2022
Merged

[fastcgi] Fix release-only build #22672

merged 1 commit into from
Jan 26, 2022

Conversation

mkhon
Copy link
Contributor

@mkhon mkhon commented Jan 21, 2022

Describe the pull request

Fix release-only build

  • What does your PR fix?

Fix release-only build

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fastcgi/vcpkg.json
  • ports/gtk3mm/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/fastcgi/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@JackBoosY JackBoosY changed the title Fix release-only build [fastcgi] Fix release-only build Jan 21, 2022
@JackBoosY JackBoosY added the category:port-bug The issue is with a library, which is something the port should already support label Jan 21, 2022
ports/fastcgi/vcpkg.json Outdated Show resolved Hide resolved
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 21, 2022
@ras0219-msft
Copy link
Contributor

This LGTM, but it has conflicts preventing the merge. Could you take a look?

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label Jan 25, 2022
@Cheney-W Cheney-W added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jan 25, 2022
@ras0219-msft ras0219-msft merged commit 42bfc0e into microsoft:master Jan 26, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

@mkhon mkhon deleted the fix/fastcgi-release-only branch January 26, 2022 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants