Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[levmar] Remove vcpkg_fail_port_install. #22726

Merged
merged 1 commit into from
Jan 24, 2022

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Jan 24, 2022

I changed the supports to speak "positively" rather than "negatively" because it seems like that was the intent based on the message.

In support of #21502

I changed the supports to speak "positively" rather than "negatively" because it seems like that was the intent based on the message.
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one portfile where deprecated functions are used.

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

  • ports/levmar/portfile.cmake

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/levmar/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

@BillyONeal BillyONeal added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 24, 2022
@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines labels Jan 24, 2022
@BillyONeal BillyONeal merged commit 7488b4c into microsoft:master Jan 24, 2022
@BillyONeal BillyONeal deleted the levmar_fail_port_install branch January 24, 2022 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants