-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[murmurhash] Remove vcpkg_fail_port_install. #22749
[murmurhash] Remove vcpkg_fail_port_install. #22749
Conversation
There was no supports expression before so there was ci.baseline.txt impact. In support of microsoft#21502
26e363f
to
c3e7603
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 485e459074a75da1650e25768e6de3d546d2036e -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index ec84f26..85aa5c4 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4618,7 +4618,7 @@
},
"murmurhash": {
"baseline": "2016-01-09",
- "port-version": 4
+ "port-version": 5
},
"mvfst": {
"baseline": "0.1",
diff --git a/versions/m-/murmurhash.json b/versions/m-/murmurhash.json
index a341221..090b6a7 100644
--- a/versions/m-/murmurhash.json
+++ b/versions/m-/murmurhash.json
@@ -1,5 +1,10 @@
{
"versions": [
+ {
+ "git-tree": "bbaeb761deb522f06cde0e3efb0610ac3e6afa4d",
+ "version-date": "2016-01-09",
+ "port-version": 5
+ },
{
"git-tree": "5c0ccc0561113eac6ab8881d62a94f31a4ab8d70",
"version-string": "2016-01-09",
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/murmurhash/portfile.cmake
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/murmurhash/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/murmurhash/portfile.cmake
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/murmurhash/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
There was no supports expression before so there was ci.baseline.txt impact.
In support of #21502