Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[septag-dmon] New port #22828

Merged
merged 22 commits into from
May 9, 2022
Merged

[septag-dmon] New port #22828

merged 22 commits into from
May 9, 2022

Conversation

SamuelMarks
Copy link
Contributor

Describe the pull request

dmon is a tiny C library that monitors changes in a directory.
It provides a unified solution to multiple system APIs that exist for each OS. It can also monitor directories recursively.

  • Windows: ReadDirectoryChangesW backend. Tested with Windows10 SDK + Visual Studio 2019
  • Linux: inotify backend. Tested with gcc-7.4/clang-6, ubuntu 18.04 LTS
  • MacOS: FSEvents backend. Tested with MacOS-10.14 clang 10

https://github.com/septag/dmon

I've opened a PR there giving C89 and CMake

  • Which triplets are supported/not supported? Have you updated the CI baseline?

all

Yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/dmon/vcpkg.json

Valid values for the license field are listed at https://spdx.org/licenses/

ports/dmon/portfile.cmake Outdated Show resolved Hide resolved
ports/dmon/vcpkg.json Outdated Show resolved Hide resolved
ports/dmon/portfile.cmake Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jan 28, 2022
ports/dmon/vcpkg.json Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft added the depends:upstream-changes Waiting on a change to the upstream project label Feb 1, 2022
ports/dmon/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL added requires:author-response and removed depends:upstream-changes Waiting on a change to the upstream project labels Feb 8, 2022
ports/dmon/portfile.cmake Outdated Show resolved Hide resolved
ports/dmon/vcpkg.json Outdated Show resolved Hide resolved
@LilyWangLL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@LilyWangLL
Copy link
Contributor

LilyWangLL commented May 5, 2022

Ping @SamuelMarks for response. Is work still being done for this PR? And could you please resolve the conflicts?

@SamuelMarks
Copy link
Contributor Author

@LilyWangLL Fixed

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label May 6, 2022
@BillyONeal
Copy link
Member

I'm a bit concerned about this name. When I put "dmon" into repology I get an existing hit (https://repology.org/project/dmon/versions) for https://github.com/aperezdc/dmon rather than this library, but googling for "dmon c++" returns this one. Would you be willing to accept septag-dmon?

@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 6, 2022
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great as long as we are OK with the name.

@BillyONeal
Copy link
Member

(I asked other maintainers what they think on the name BTW, but if you'd accept the longer name it would short circuit that)

@vicroms
Copy link
Member

vicroms commented May 6, 2022

To avoid confusion for users and in the spirit of fairness. We should name this port septag-dmon and disallow any port to be named just dmon in the future.

If the project Billy mentioned gets added to vcpkg it will have to be named aperezdc-dmon.

This also prevents issues with versioning where old versions of the port would be named differently and have their own versions file and database entries.

@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 7, 2022
@BillyONeal BillyONeal changed the title [dmon] New port [septag-dmon] New port May 9, 2022
@BillyONeal BillyONeal merged commit 0c5bb65 into microsoft:master May 9, 2022
@BillyONeal
Copy link
Member

Thanks for the new port!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants