-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[septag-dmon] New port #22828
[septag-dmon] New port #22828
Conversation
… --all --overwrite-version`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/dmon/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
…ion`; manually remove old versions
/azp run |
Pull request contains merge conflicts. |
Ping @SamuelMarks for response. Is work still being done for this PR? And could you please resolve the conflicts? |
…ert to `07e508359ca5488456988191d8709722484daccd`
@LilyWangLL Fixed |
I'm a bit concerned about this name. When I put "dmon" into repology I get an existing hit (https://repology.org/project/dmon/versions) for https://github.com/aperezdc/dmon rather than this library, but googling for "dmon c++" returns this one. Would you be willing to accept septag-dmon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great as long as we are OK with the name.
(I asked other maintainers what they think on the name BTW, but if you'd accept the longer name it would short circuit that) |
To avoid confusion for users and in the spirit of fairness. We should name this port If the project Billy mentioned gets added to vcpkg it will have to be named This also prevents issues with versioning where old versions of the port would be named differently and have their own versions file and database entries. |
Thanks for the new port! |
Describe the pull request
https://github.com/septag/dmon
I've opened a PR there giving C89 and CMake
Which triplets are supported/not supported? Have you updated the CI baseline?
all
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes