Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[muparser] Fix usage #22975

Merged
merged 6 commits into from
Feb 9, 2022
Merged

[muparser] Fix usage #22975

merged 6 commits into from
Feb 9, 2022

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 7, 2022 •
edited
Loading

Fixes #22966.

Already tested all features.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Feb 7, 2022
@JackBoosY JackBoosY requested a review from JonLiu1993 February 7, 2022 07:51
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 7, 2022
Neumann-A
Neumann-A reviewed Feb 7, 2022
View reviewed changes
ports/muparser/vcpkg.json Outdated Show resolved Hide resolved
@JonLiu1993 JonLiu1993 added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 7, 2022
@JackBoosY JackBoosY changed the title [muparser] Fix usage and add feature widechar [muparser] Fix usage Feb 8, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Feb 9, 2022
@ras0219-msft ras0219-msft merged commit e2c7976 into microsoft:master Feb 9, 2022
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/22966 branch February 9, 2022 05:38
@robekras
Copy link

robekras commented Apr 3, 2024

With this 'fix':

#vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/muParserDef.h" "#if defined(_UNICODE)" "#if 0")
#vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/muParserDLL.h" "#ifndef _UNICODE" "#if 1")

it is not possible to build a program which is set for using _UNICODE,
as this 'fix' will deactivate all the _UNICODE dependencies within the muparser library.
Maybe the better would be, as is at it was stated in #22966: Make this dependent on the setting of DENABLE_WIDE_CHAR

@JackBoosY
Copy link
Contributor Author

With this 'fix':

#vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/muParserDef.h" "#if defined(_UNICODE)" "#if 0")
#vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/muParserDLL.h" "#ifndef _UNICODE" "#if 1")

it is not possible to build a program which is set for using _UNICODE, as this 'fix' will deactivate all the _UNICODE dependencies within the muparser library. Maybe the better would be, as is at it was stated in #22966: Make this dependent on the setting of DENABLE_WIDE_CHAR

Can you please open a new issue for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Osyotr Osyotr Osyotr left review comments

@Neumann-A Neumann-A Neumann-A approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[muparser] Linkage not hardcoded/ wide character set not hardcoded
6 participants
@JackBoosY @ras0219-msft @robekras @Osyotr @Neumann-A @JonLiu1993