-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Qt6] update to 6.3.0 #23015
Merged
Merged
[Qt6] update to 6.3.0 #23015
Changes from 22 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
f110090
[Qt6] Latest feature to 6.3.0
Neumann-A 89650ee
move failing patch to !latest
Neumann-A b09fd1a
remove debug/include
Neumann-A 7fd896c
more fixes
Neumann-A 812bc98
more fixes
Neumann-A 40000f3
more fixes
Neumann-A e92ccda
give me the binary names making it fail.
Neumann-A 85fc90f
add new binary
Neumann-A 3aa1b72
fix qtimageformats
Neumann-A 2bf636f
fix regressions?
Neumann-A 1652c8d
retry qtopcua
Neumann-A 322ebb6
fix regressions
Neumann-A 1b68184
correctly guard python
Neumann-A 1ea2dc8
more fixes
Neumann-A 8007317
add vcpkg-get-python-packages
Neumann-A 3e7e7c6
hack webengine build to see if it will work.
Neumann-A 2395a1e
move hack to a different position
Neumann-A c97afeb
noramlize path
Neumann-A 64aa207
Merge remote-tracking branch 'upstream/master' into qt6_update_6.3.0
80d5de4
update refs to 6.3 release
2a01e07
fix details
Neumann-A dd4f0ed
qtwebengine back to fail on baseline
Neumann-A c5148dd
comment long path stuff out since qtwebengine cannot be build with VS…
af9c755
Merge remote-tracking branch 'upstream/master' into qt6_update_6.3.0
42f30aa
update version to 6.3.0 in manifest files
efd0994
version stuff
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
diff --git a/cmake/QtPostProcessHelpers.cmake b/cmake/QtPostProcessHelpers.cmake | ||
index 4f8106dfa..bec5c402e 100644 | ||
--- a/cmake/QtPostProcessHelpers.cmake | ||
+++ b/cmake/QtPostProcessHelpers.cmake | ||
@@ -414,7 +414,7 @@ function(qt_generate_install_prefixes out_var) | ||
|
||
foreach(var ${vars}) | ||
get_property(docstring CACHE "${var}" PROPERTY HELPSTRING) | ||
- string(APPEND content "set(${var} \"${${var}}\" CACHE STRING \"${docstring}\" FORCE)\n") | ||
+ string(APPEND content "set(${var} \"${${var}}\" CACHE STRING \"${docstring}\")\n") | ||
endforeach() | ||
|
||
set(${out_var} "${content}" PARENT_SCOPE) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
diff --git a/CMakeLists.txt b/CMakeLists.txt | ||
index 7fdd7ddbd..f189c472c 100644 | ||
--- a/CMakeLists.txt | ||
+++ b/CMakeLists.txt | ||
@@ -9,6 +9,15 @@ project(QtImageFormats # special case | ||
HOMEPAGE_URL "https://qt.io/" | ||
LANGUAGES CXX C | ||
) | ||
- | ||
+find_package(Threads) | ||
+set_property(TARGET Threads::Threads PROPERTY _qt_no_promote_global TRUE) | ||
+find_package(ZLIB) | ||
+if(TARGET ZLIB::ZLIB) | ||
+ set_property(TARGET ZLIB::ZLIB PROPERTY _qt_no_promote_global TRUE) | ||
+endif() | ||
+find_package(JPEG) | ||
+if(TARGET JPEG::JPEG) | ||
+ set_property(TARGET JPEG::JPEG PROPERTY _qt_no_promote_global TRUE) | ||
+endif() | ||
find_package(Qt6 ${PROJECT_VERSION} CONFIG REQUIRED COMPONENTS BuildInternals Core) # special case | ||
find_package(Qt6 ${PROJECT_VERSION} QUIET CONFIG OPTIONAL_COMPONENTS Gui) # special case |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -40,6 +40,7 @@ | |
"default-features": false, | ||
"features": [ | ||
"amalgamation", | ||
"historizing", | ||
"openssl" | ||
] | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ras0219-msft @BillyONeal @strega-nil: So what should I do here? I need shorter paths for CI to succeed. Having
<buildtreeroot>/<port>/src/<12 characters>.clean/
and<buildtreeroot>/<port>/<triplet>-<config>/
are simply too long.I would suggest a way to shorten
<buildtreeroot>/<port>/src/<21 characters>.clean/
to<buildtreeroot>/<port>/src/<3 characters>.c/
and<buildtreeroot>/<port>/<triplet>-<config>/
to<buildtreeroot>/<port>/<3 char triplet hash>-<config>/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm personally in favor of a change like that but given that qt-webengine seems to be consuming everything we ever give it I think qt-webengine needs to take some ownership of the problem they have created here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is really ninja which is not long path aware. Otherwise you need to be pointing fingers at vcpkg+qt+cmake.
MAX_PATH
if--x-buildtrees-root
is set to a short path... otherwise moreqtwebengine
for being deeply nested (~50-60% of MAX_PATH) andchromium
having 3rd party deps with 3rd party deps. (so the problem here is chromium not qtwebengine.)the whole problem goes away if ninja has long path support. (I mean I could switch generators to NMake+JOM but who would want that considering the random hangs of JOM?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently I think we don't have a good solution for it, we can only print a message to notify the user to use
--x-buildtrees-root=<SHORT_PATH>
to avoid this.