-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg docs] Remove deprecated functions from docs #23018
Conversation
@Thomas1664 ,Thanks for your pr, It looks like CI is failing because of format issues, could you please take a look?
|
@JonLiu1993 |
Nothing needed to revert. Just apply the original changes to the scripts. Then regenerate the doc files with the powershell script in the doc dir. |
I applied the changes in the scripts. The powershell script doesn't work because I get a bunch of errors. |
That's a pity. It works in CI and even on Linux. |
Hopefully I don't need to run it because I edited the docs already directly. Lets see if CI complains... |
Great! Now that I edited the scripts CI builds every port |
... that depends on the scripts. Last time discussed here: #21763 (comment) ff. |
@JonLiu1993 , |
colmap:x64-osx : this error is not introduced by this pr, we are fixing CI |
Cycled the PR in order to get CLA bot to be happy |
Describe the pull request
What does your PR fix?
Fixes Don't use deprecated funtions in your examples #17178
Remove use of deprecated cmake functions in the docs
Use quotes for paths in examples
Which triplets are supported/not supported? Have you updated the CI baseline?
No
Does your PR follow the maintainer guide?
Yes