-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Publish test results #23477
[ci] Publish test results #23477
Conversation
Findings:
|
Possible changes for vcpkg-tool xUnit output
References: |
There is now also aggregated data for the "pipeline": |
cc @BillyONeal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/cmake-user/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/cmake-user/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: d9b335de3825f7538c76162745c1e0bf3010e783
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/cmake-user/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
Error: Local changes detected for librttopo but no changes to version or port version.
-- Version: 1.1.0#5
-- Old SHA: d747c88d429ff781b11627623d0958967f912a41
-- New SHA: 5819abd14ead64303849e59b258dc8c492125610
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
scripts/test_ports/cmake-user/vcpkg.json
Valid values for the license field can be found in the documentation
I think this is good enough for merge now. I couldn't find out why the features aren't displayed reliably. Maybe this it is just a side effect of the work being in progress in this PR. CC @BillyONeal |
Are you happy with saying microsoft/vcpkg-tool#437 implements all the powershell stuff here and that only the stuff to get AzureDevOps to upload the bits should be kept here? (I understand not wanting to touch this until that lands in an actual tool release, I just want to make sure we're on the same page though) |
I'm happy when the tool does the main work soon, and this PR can wait. However, it will make it harder to experiment with any further improvements. That's why I wonder if it shouldn't be merged as a script first. |
Our experience is that such scripts become impenetrable messes and we've really been trying to make sure anything new that we do is done in the tool proper. Yes, that means we need a better end to end test experience to try out tool changes, and I'm on the hook to do that, and will be doing it after this Patch Tuesday where I get enough bits to build ourselves installed-by-default in the build lab. |
…ss. (#437) * Reduce build output chattiness. This change deletes the word "package" from several places where it is clear, and deduplicates "starting install" and "installing" messages. Before: ``` PS C:\Dev\vcpkg> .\vcpkg.exe install zlib Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 43.57 ms. Use --debug to see more details. Starting package 1/1: zlib:x86-windows Installing package zlib[core]:x86-windows... Elapsed time for package zlib:x86-windows: 18.41 ms Total elapsed time: 2.266 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing package zlib:x86-windows... PS C:\Dev\vcpkg> .\vcpkg.exe install zlib --no-binarycaching Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Starting package 1/1: zlib:x86-windows Building package zlib[core]:x86-windows... -- Using cached zlib1211.tar.gz. -- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz -- Applying patch cmake_dont_build_more_than_needed.patch -- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch -- Applying patch add_debug_postfix_on_mingw.patch -- Applying patch 0002-android-build-mingw.patch -- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean -- Configuring x86-windows -- Building x86-windows-dbg -- Building x86-windows-rel -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc -- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst. -- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst. -- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195 -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright -- Performing post-build validation -- Performing post-build validation done Installing package zlib[core]:x86-windows... Elapsed time for package zlib:x86-windows: 4.83 s Total elapsed time: 7.009 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> .\vcpkg.exe x-set-installed The following packages will be removed: zlib:x86-windows Starting package 1/1: zlib:x86-windows Removing package zlib:x86-windows... Elapsed time for package zlib:x86-windows: 9.93 ms Restored 0 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 92.5 us. Use --debug to see more details. Total elapsed time: 14.01 ms PS C:\Dev\vcpkg> .\vcpkg.exe remove zlib The following packages are not installed, so not removed: zlib:x86-windows Package zlib:x86-windows is not installed PS C:\Dev\vcpkg> ``` After: ``` PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Restored 1 packages from C:\Users\bion\AppData\Local\vcpkg\archives in 60.79 ms. Use --debug to see more details. Installing zlib:x86-windows (1/1)... Elapsed time for zlib:x86-windows: 20.03 ms Total elapsed time: 2.662 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe install zlib --no-binarycaching Computing installation plan... The following packages will be built and installed: zlib[core]:x86-windows -> 1.2.11#13 Detecting compiler hash for triplet x86-windows... Installing zlib:x86-windows (1/1)... Building zlib[core]:x86-windows... -- Using cached zlib1211.tar.gz. -- Cleaning sources at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean. Use --editable to skip cleaning for the packages you specify. -- Extracting source C:/Dev/vcpkg-downloads/zlib1211.tar.gz -- Applying patch cmake_dont_build_more_than_needed.patch -- Applying patch 0001-Prevent-invalid-inclusions-when-HAVE_-is-set-to-0.patch -- Applying patch add_debug_postfix_on_mingw.patch -- Applying patch 0002-android-build-mingw.patch -- Using source at C:/Dev/vcpkg/buildtrees/zlib/src/1.2.11-e9a093319e.clean -- Configuring x86-windows -- Building x86-windows-dbg -- Building x86-windows-rel -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/vcpkg-cmake-wrapper.cmake -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/lib/pkgconfig/zlib.pc -- Using cached msys-mingw-w64-i686-pkg-config-0.29.2-3-any.pkg.tar.zst. -- Using cached msys-mingw-w64-i686-libwinpthread-git-9.0.0.6373.5be8fcd83-1-any.pkg.tar.zst. -- Using msys root at C:/Dev/vcpkg-downloads/tools/msys2/9a1ec3f33446b195 -- Fixing pkgconfig file: C:/Dev/vcpkg/packages/zlib_x86-windows/debug/lib/pkgconfig/zlib.pc -- Installing: C:/Dev/vcpkg/packages/zlib_x86-windows/share/zlib/copyright -- Performing post-build validation -- Performing post-build validation done Elapsed time for zlib:x86-windows: 5.137 s Total elapsed time: 7.36 s The package zlib is compatible with built-in CMake targets: find_package(ZLIB REQUIRED) target_link_libraries(main PRIVATE ZLIB::ZLIB) PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages will be removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ..\vcpkg-tool\out\build\x64-Debug\vcpkg.exe remove zlib The following packages are not installed, so not removed: zlib:x86-windows Removing zlib:x86-windows (1/1)... PS C:\Dev\vcpkg> ``` * Built in implementation of microsoft/vcpkg#23477 . Needs tests. * Fix POSIX build failures. * ref-ize SpecSummary as re quested by @dg0yt * Use XmlSerializer to generate xUnit results * Localize touched messages Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
https://dev.azure.com/vcpkg/public/_build/results?buildId=73559&view=ms.vss-test-web.build-test-results-tab
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for librttopo have changed but the version was not updated
version: 1.1.0#5
old SHA: d747c88d429ff781b11627623d0958967f912a41
new SHA: 144a5d16e71f2ceec96373e3f26b71d704bb9bec
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
With the updated post-processing (which should be equivalent to microsoft/vcpkg-tool#585), it is better again. |
This is one of the most amazing contributions ever, thank you so much again! |
* Update vcpkg-tool to 2022-06-15. See https://github.com/microsoft/vcpkg-tool/releases/tag/2022-06-15 * Add `=pass` entries from microsoft/vcpkg-tool#579 * Cherry pick XUnit output from #23477 which hooks up microsoft/vcpkg-tool#585 (Thanks again @dg0yt !) * Update release process document now that we can do the full tree rebuild to test the tool release before signing. Thank you: @autoantwort @christophe-calmejane @JackBoosY @benmcmorran @hmoffatt @klalumiere @Thomas1664 @Neumann-A @AenBleidd for your contributions! Fixes #22686 . Fixes #21800 . Fixes #16216 . Fixes #15836 . Full tree rebuild testing this update is: https://dev.azure.com/vcpkg/public/_build/results?buildId=73664&view=results
Any progress on this PR? (I will keep this PR open anyway) |
Progress is at 137%. Xunit output was improved directly in vcpkg tool, and CI test result upload has been added in other PRs. For future improvements, I can open a new PR. |
PS: I added a branch protection rule to my fork so that the history with the XML post-processing remains accessible for reference. |
What does your PR fix?
Publish CI results as AZP test results.
Which triplets are supported/not supported? Have you updated the CI baseline?
--
Does your PR follow the maintainer guide?
--
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?--