Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[arb] Support dynamic build #23743

Merged
merged 2 commits into from
Mar 24, 2022
Merged

[arb] Support dynamic build #23743

merged 2 commits into from
Mar 24, 2022

Conversation

JackBoosY
Copy link
Contributor

Adds dynamic build support for arb since gmp fixes symbols issue, since arb's exported symbol declaration depends on flint's exported symbol declaration:

#if defined(_MSC_VER) && defined(ARB_BUILD_DLL)
#define ARB_DLL __declspec(dllexport)
#else
#define ARB_DLL FLINT_DLL
#endif

Fixes #23699.

@JackBoosY JackBoosY added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Mar 24, 2022
@JackBoosY
Copy link
Contributor Author

@kaba2 Please git pull vcpkg and checkout this branch to test.

Thanks.

@JackBoosY JackBoosY requested a review from Adela0814 March 24, 2022 06:27
@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Mar 24, 2022
@kaba2
Copy link

kaba2 commented Mar 24, 2022

@JackBoosY I tested the branch, and it works! Many thanks.

@dan-shaw dan-shaw merged commit fc69905 into microsoft:master Mar 24, 2022
@JackBoosY JackBoosY deleted the dev/jack/23699 branch March 25, 2022 02:51
ekilmer added a commit to ekilmer/vcpkg that referenced this pull request Mar 26, 2022
@ekilmer
Merge branch 'master' into more-lief
558f302 
* master: (103 commits)
  [lmdb] don't use msvc parameters with non-msvc compiler (microsoft#23653)
  Fix <version> of Python in vcpkgTools.xml (microsoft#23751)
  [sciter] escape quotes (microsoft#23752)
  [fuzzylite] Fix Linux build (microsoft#23658)
  [cpp-redis] Fix ‘sleep_for’ is not a member of ‘std::this_thread’ (microsoft#23762)
  [nlohmann-json] Fix usage text (microsoft#23749)
  [fontconfig] Do not create symlinks (microsoft#23735) (microsoft#23736)
  [winsparkle] Fix header file and debug path (microsoft#23739)
  [arb] Support dynamic build (microsoft#23743)
  [aws-sdk-cpp] update to 1.9.220 (microsoft#23729)
  Fix the VS2022 'unstable' queues. (microsoft#23742)
  [xmlsec] Bump to 1.2.33 (microsoft#23733)
  [unicorn] update to latest version v1.0.3 (microsoft#23745)
  [libpq] Update version to 14.1 2 (microsoft#22516)
  [libnoise] Export CMake files (microsoft#23682)
  [vcpk-ci] Trigger some test ports from vcpkg.cmake changes (microsoft#23430)
  [nlohmann-json] Add option to control implicit conversions behaviour (microsoft#22409)
  [libjuice] Update to 0.9.8 (microsoft#23153)
  [libgeotiff] Update to 1.7.1 (microsoft#23446)
  [minizip-ng] Updated minizip version and fixed windows build for previous version (microsoft#23684)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[arb] Arb package cannot be used to build programs
4 participants
@JackBoosY @kaba2 @Adela0814 @dan-shaw