Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rendergraph] Add port. #23955

Merged
merged 5 commits into from
Apr 6, 2022
Merged

[rendergraph] Add port. #23955

merged 5 commits into from
Apr 6, 2022

Conversation

DragonJoker
Copy link
Contributor

Describe the pull request

  • What does your PR fix?

    Fixes [New Port Request] RenderGraph #23954

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    I've tested it with x64-windows, x64-windows-static, x64-linux and x64-osx.
    The CI baseline has not been updated.

  • Does your PR follow the maintainer guide?

    Hopefully

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes

@DragonJoker DragonJoker marked this pull request as ready for review April 3, 2022 09:29
@DragonJoker DragonJoker marked this pull request as draft April 4, 2022 16:01
@DragonJoker DragonJoker marked this pull request as ready for review April 4, 2022 16:15
@JonLiu1993 JonLiu1993 self-assigned this Apr 6, 2022
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Apr 6, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Apr 6, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for shaderwriter but no changes to version or port version.
-- Version: 2.1.0
-- Old SHA: e9ad5b26c40e2048a99c618972827c8f8e802eaa
-- New SHA: b11df3d934389885ded9869b7d3b978911f2a687
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for shaderwriter but no changes to version or port version.
-- Version: 2.1.0
-- Old SHA: e9ad5b26c40e2048a99c618972827c8f8e802eaa
-- New SHA: b11df3d934389885ded9869b7d3b978911f2a687
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 1f31840e88d3cc3bae9af545fa6653f579800fcb -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/s-/shaderwriter.json b/versions/s-/shaderwriter.json
index d8d0c60..4c30eff 100644
--- a/versions/s-/shaderwriter.json
+++ b/versions/s-/shaderwriter.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "b11df3d934389885ded9869b7d3b978911f2a687",
+      "git-tree": "e9ad5b26c40e2048a99c618972827c8f8e802eaa",
       "version": "2.1.0",
       "port-version": 0
     },

@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit baae2dd into microsoft:master Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] RenderGraph
4 participants