[openssl] Fix building in Release only mode #24004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for openssl but no changes to version or port version.
-- Version: 3.0.2
-- Old SHA: 2ba2e59ee4f32c11e30aeccc0ecabc09b69c5d22
-- New SHA: 9c3f6ad15d765bc9e5c8754dea85793bd33d4183
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
This is a fix for #22878 (comment) |
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
AenBleidd
force-pushed
the
vko_fix_openssl_for_release_only_builds
branch
from
64f6d24 to
4493e92
Compare
Neumann-A
reviewed
Apr 6, 2022
Co-authored-by: Alexander Neumann <30894796+Neumann-A@users.noreply.github.com>
…ssl_for_release_only_builds
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 59facb4cf71bff961a7a7fe18ffa07539c19183f -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/o-/openssl.json b/versions/o-/openssl.json
index d64cbab..7734cda 100644
--- a/versions/o-/openssl.json
+++ b/versions/o-/openssl.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "6abb68591e9636cdf310ce1d1c3a04e3ebce9cab",
+ "git-tree": "7f45a98732d599c67e9cf0069783308f71f8666a",
"version": "3.0.2",
"port-version": 1
},…AenBleidd/vcpkg into vko_fix_openssl_for_release_only_builds Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
strega-nil-ms
approved these changes
Apr 6, 2022
strega-nil-ms
added
the
info:reviewed
Signed-off-by: Vitalii Koshura <lestat.de.lionkur@gmail.com>
|
Merged #23932 as @strega-nil-ms asked |
JackBoosY
added
the
category:port-bug
JackBoosY
approved these changes
Apr 7, 2022
Closed
|
anxiously waiting for this fix to land |
|
Thanks! |
|
still doesn't work. same error as reported in #24003 |
|
@winterz, I'll take a look at this issue tonight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitalii Koshura lestat.de.lionkur@gmail.com