-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[antlr4] Fix CMake files export #24157
[antlr4] Fix CMake files export #24157
Conversation
Cool, LGTM! |
@LilyWangLL is there any chance you could leverage your recent ANTLR4 momentum to quickly upgrade it to 4.10.1? |
I will do this week. |
Hm, just trying this now and I don't see anything like
when I add |
Sorry, I had forgotten to run |
Just wondering if you got a chance to make this upgrade :) |
Sorry, I updated this port locally before, but the new version has some errors that need to be resolved, I will resolve them as soon as possible and submit a PR. |
I hope the errors are easy to resolve the second time they come up! |
PR #25416 will update |
Fixes #17030, add CMake files export for antlr4.