Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[antlr4] Fix CMake files export #24157

Merged
merged 5 commits into from
Apr 18, 2022

Conversation

LilyWangLL
Copy link
Contributor

Fixes #17030, add CMake files export for antlr4.

@LilyWangLL LilyWangLL added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. labels Apr 15, 2022
ports/antlr4/portfile.cmake Outdated Show resolved Hide resolved
@LilyWangLL LilyWangLL marked this pull request as ready for review April 16, 2022 13:33
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Apr 18, 2022
@strega-nil-ms
Copy link
Contributor

Cool, LGTM!

@strega-nil-ms strega-nil-ms merged commit d35a986 into microsoft:master Apr 18, 2022
@NickStrupat
Copy link
Contributor

@LilyWangLL is there any chance you could leverage your recent ANTLR4 momentum to quickly upgrade it to 4.10.1?
There were a bunch of improvements for the C++ target.

@LilyWangLL
Copy link
Contributor Author

@LilyWangLL is there any chance you could leverage your recent ANTLR4 momentum to quickly upgrade it to 4.10.1? There were a bunch of improvements for the C++ target.

I will do this week.

@NickStrupat
Copy link
Contributor

NickStrupat commented May 7, 2022

Hm, just trying this now and I don't see anything like

The package antlr4 provides CMake targets:

    find_package(antlr4-runtime CONFIG REQUIRED)
    target_link_libraries(main PRIVATE antlr4::antlr4)

when I add antlr4 to my vcpkg.json and then run ./vcpkg install

@NickStrupat
Copy link
Contributor

Sorry, I had forgotten to run git submodule update --remote in my project to get the latest changes made in this PR.

@LilyWangLL LilyWangLL deleted the dev/LilyWang/issue17030 branch May 17, 2022 03:04
@NickStrupat
Copy link
Contributor

@LilyWangLL is there any chance you could leverage your recent ANTLR4 momentum to quickly upgrade it to 4.10.1? There were a bunch of improvements for the C++ target.

I will do this week.

Just wondering if you got a chance to make this upgrade :)

@LilyWangLL
Copy link
Contributor Author

@LilyWangLL is there any chance you could leverage your recent ANTLR4 momentum to quickly upgrade it to 4.10.1? There were a bunch of improvements for the C++ target.

I will do this week.

Just wondering if you got a chance to make this upgrade :)

Sorry, I updated this port locally before, but the new version has some errors that need to be resolved, I will resolve them as soon as possible and submit a PR.

@NickStrupat
Copy link
Contributor

I hope the errors are easy to resolve the second time they come up!

@LilyWangLL
Copy link
Contributor Author

I hope the errors are easy to resolve the second time they come up!

PR #25416 will update antlr4 to 4.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[antlr4] Add cmake targets to port
5 participants