Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apr] Fix release only builds on Linux #24220

Merged
merged 2 commits into from
Apr 19, 2022
Merged

[apr] Fix release only builds on Linux #24220

merged 2 commits into from
Apr 19, 2022

Conversation

Thomas1664
Copy link
Contributor

Describe the pull request

Adela0814
Adela0814 suggested changes Apr 19, 2022
View reviewed changes
ports/apr/portfile.cmake Show resolved Hide resolved
ports/apr/portfile.cmake Show resolved Hide resolved
ports/apr/portfile.cmake Show resolved Hide resolved
@Adela0814 Adela0814 added category:port-bug The issue is with a library, which is something the port should already support requires:author-response labels Apr 19, 2022
dg0yt
dg0yt reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In portfiles, VCPKG_BUILD_TYPE can be false or release. Single-config debug is not supported. So the if code is okay. It is also accepted in all recent PRs.

@Adela0814
Copy link
Contributor

In portfiles, VCPKG_BUILD_TYPE can be false or release. Single-config debug is not supported. So the if code is okay. It is also accepted in all recent PRs.

ok, got it.

@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 19, 2022
@strega-nil-ms
Copy link
Contributor

Thanks!

@strega-nil-ms strega-nil-ms merged commit 277e5eb into microsoft:master Apr 19, 2022
@Thomas1664 Thomas1664 deleted the apr branch April 19, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

@Adela0814 Adela0814 Adela0814 approved these changes

Assignees

@Adela0814 Adela0814

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
4 participants
@Thomas1664 @Adela0814 @strega-nil-ms @dg0yt