Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tensorflow-cc] Update to 2.10.0 #24861

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Conversation

JackyYin
Copy link
Contributor

@JackyYin JackyYin commented May 22, 2022

Update tensorflow-cc to 2.10.0.

Bacause tensorflow-cc depends on tensorflow-common and tensorflow depends on tensorflow-common too, so I update all of these package to 2.10.0 at once.

Also added a new host port vcpkg-tool-bazel as a dependency of tensorflow and tensorflow-cc, bacause tensorflow 2.10.0 requires newer version of bazel.

Tested triplet:
x64-osx
x64-linux
arm64-osx

@JackyYin JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 5aaf4d2 to eae9113 Compare May 22, 2022 13:40
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/tensorflow-cc/vcpkg.json
  • ports/tensorflow-common/vcpkg.json
  • ports/tensorflow/vcpkg.json

Valid values for the license field can be found in the documentation

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/tensorflow-cc/vcpkg.json
  • ports/tensorflow-common/vcpkg.json
  • ports/tensorflow/vcpkg.json

Valid values for the license field can be found in the documentation

@JackyYin JackyYin force-pushed the tensorflow-cc-2.8.0 branch from eae9113 to 83a8121 Compare May 22, 2022 13:48
@JackyYin JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 83a8121 to 49f294a Compare May 22, 2022 14:03
@JackyYin JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 49f294a to 7ab0dc4 Compare May 22, 2022 14:12
@JonLiu1993 JonLiu1993 self-assigned this May 23, 2022
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 23, 2022
JonLiu1993
JonLiu1993 previously approved these changes May 23, 2022
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 23, 2022
@ras0219-msft
Copy link
Contributor

Thanks for the PR!

Can we be more surgical about these removals? What are they specifically removing? We should be redirecting all bazel files to stay within the vcpkg instance.

@ras0219-msft ras0219-msft added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels May 23, 2022
@JackyYin
Copy link
Contributor Author

JackyYin commented May 24, 2022

Hello @ras0219-msft,

Can we be more surgical about these removals? What are they specifically removing? We should be redirecting all bazel files to stay within the vcpkg instance.

This is where my pipeline failed : https://dev.azure.com/vcpkg/public/_build/results?buildId=72552&view=logs&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad.

Firstly, the Create /home/agent and Create /mnt/vcpkg-ci and /mnt/vcpkg-ci/downloads steps both have the same error message:

cannot create directory ‘xxxx’: File exists

Then in the Test Modified Ports for x64-linux step, we can see following error:

Starting vcpkg CI clean
Clearing contents of /mnt/vcpkg-ci/buildtrees
Failure to remove_all_inside("/mnt/vcpkg-ci/buildtrees") due to file "/mnt/vcpkg-ci/buildtrees/tensorflow/.bzl/02c0d9509a4399b7d0b466397e539271/sandbox/inaccessibleHelperDir": Permission denied
Exception: /agent/_work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:132
Line |
 132 |      throw "vcpkg clean failed"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg clean failed

##[error]PowerShell exited with code '1'.
##[error]PowerShell wrote one or more lines to the standard error stream.
##[error]Exception: /agent/_work/1/s/scripts/azure-pipelines/test-modified-ports.ps1:132
Line |
 132 |      throw "vcpkg clean failed"
     |      ~~~~~~~~~~~~~~~~~~~~~~~~~~
     | vcpkg clean failed

Seems like it's an error raised from vcpkg x-ci-clean command, which failed to remove /mnt/vcpkg-ci/buildtrees directory.

IMHO, it's a better idea to cleanup those working directory, so we can get a fresh work space everytime when we trigger the workflow.

@JackyYin
Copy link
Contributor Author

Hello @ras0219-msft ,
Any update or comment here?

@JonLiu1993
Copy link
Member

@ras0219-msft ,Could you please take a review?

@abique
Copy link
Contributor

abique commented Jun 13, 2022

2.9.0 is out now.

@JonLiu1993
Copy link
Member

@JackyYin ,Could you please update tensorflow-cc to the lateste version 2.9.0?

@abique
Copy link
Contributor

abique commented Jun 14, 2022

By the way, is it correct that tensor-flow is not supported on arm?
Because here brew can provide libtensorflow to arm m1.

@JackyYin
Copy link
Contributor Author

@JackyYin ,Could you please update tensorflow-cc to the lateste version 2.9.0?

It's my pleasure, I will update this patch as soon as possible.

JackyYin added a commit to JackyYin/vcpkg that referenced this pull request Jun 14, 2022
@JackyYin JackyYin force-pushed the tensorflow-cc-2.8.0 branch from 7ab0dc4 to e11d674 Compare June 14, 2022 09:06
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for tensorflow-common have changed but the version was not updated
version: 2.10.0
old SHA: 44ba099d1b61759bd520a48486e2b88fef616397
new SHA: 86fd281d0d4da2f16538f684741e3fa07cc98406
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

@JackyYin JackyYin changed the title [tensorflow-cc] Update to 2.9.1 [tensorflow-cc] Update to 2.10.0 Sep 21, 2022
github-actions[bot]
github-actions bot previously approved these changes Sep 21, 2022
@JackyYin
Copy link
Contributor Author

JackyYin commented Sep 21, 2022

@JackyYin TensorFlow 2.10 has been released, could you try updating this PR?

Hi @japm48,
updated Tensorflow to 2.10, please try it and let me know if there're any other problems.

@JackyYin
Copy link
Contributor Author

Hi @JonLiu1993 ,
The CI checks failed because of command vcpkg x-ci-clean, could you help to re-trigger the check?

https://dev.azure.com/vcpkg/public/_build/results?buildId=78366&view=logs&jobId=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&j=f79cfdd7-47a8-597f-8f57-dc3e21a8f2ad&t=da63cf11-1f12-503b-6d64-3b2fb713c172

@JonLiu1993
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vicroms vicroms added info:reviewed Pull Request changes follow basic guidelines and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Oct 13, 2022
Copy link
Member

@vicroms vicroms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ALittleDruid
Copy link
Contributor

build failure on Windows x64

-- Configuring TensorFlow (dbg)
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:96 (message):
Command failed: D:/vcpkg/downloads/tools/msys2/70289b324bc026d6/mingw64/bin/python3.exe D:/build/tensorflow/x64-windows-dbg/configure.py --workspace D:/build/tensorflow/x64-windows-dbg
Working Directory: D:/build/tensorflow/x64-windows-dbg
Error code: 1
See logs for more information:
D:\build\tensorflow\config-x64-windows-dbg-out.log

Call Stack (most recent call first):
installed/x64-windows/share/tensorflow-common/tensorflow-common.cmake:187 (vcpkg_execute_required_process)
ports/tensorflow/portfile.cmake:5 (include)
scripts/ports.cmake:147 (include)

config-x64-windows-dbg-out.log

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Nov 1, 2022
…0-17, he started applying use of the "embedded VERSION" feature microsoft/vcpkg-tool#717 to PRs on merge.

@dg0yt points out that this use should be accompanied by a call to vcpkg_minimum_required, in https://github.com/microsoft/vcpkg/pull/27594/files#r1010641672

This is an audit of everything merged in that time and whether it needs to gain that.

microsoft#27561 No VERSION
microsoft#27525 No VERSION
microsoft#27554 Already has vcpkg_minimum_required
microsoft#27536 No VERSION
microsoft#27562 No VERSION
microsoft#24914 Fixed here
microsoft#27547 No VERSION
microsoft#27502 No VERSION
microsoft#27497 No VERSION
microsoft#27317 No VERSION
microsoft#27288 No VERSION
microsoft#27509 No VERSION
microsoft#27504 No VERSION
microsoft#27514 No VERSION
microsoft#27501 No VERSION
microsoft#27495 No VERSION
microsoft#27488 No VERSION
microsoft#27499 No VERSION
microsoft#27378 No VERSION
microsoft#27376 Fixed here
microsoft#27373 No VERSION
microsoft#27045 No VERSION
microsoft#27521 No VERSION
microsoft#27453 No VERSION
microsoft#27481 No VERSION
microsoft#27511 No VERSION
microsoft#27490 No VERSION
microsoft#27510 No VERSION
microsoft#27496 No VERSION
microsoft#27503 No VERSION
microsoft#27485 No VERSION
microsoft#27484 No VERSION
microsoft#27483 No VERSION
microsoft#27459 No VERSION
microsoft#27369 No VERSION
microsoft#27489 No VERSION
microsoft#26594 No VERSION
microsoft#27465 No VERSION
microsoft#27456 No VERSION
microsoft#27425 No VERSION
microsoft#27464 Fixed here
microsoft#27406 No VERSION
microsoft#27398 No VERSION
microsoft#27240 No VERSION
microsoft#27450 No VERSION
microsoft#27463 No VERSION
microsoft#27462 No VERSION
microsoft#27448 No VERSION
microsoft#27440 No VERSION
microsoft#27435 No VERSION
microsoft#27424 No VERSION
microsoft#27414 No VERSION
microsoft#27412 No VERSION
microsoft#27380 No VERSION
microsoft#27343 No VERSION
microsoft#27342 No VERSION
microsoft#27367 No VERSION
microsoft#27226 No VERSION
microsoft#27320 No VERSION
microsoft#26923 No VERSION
microsoft#27284 No VERSION
microsoft#27433 No VERSION
microsoft#27314 VERSION got *removed*
microsoft#27335 No VERSION
microsoft#27370 No VERSION
microsoft#27324 No VERSION
microsoft#27391 No VERSION
microsoft#27388 No VERSION
microsoft#27396 No VERSION
microsoft#27404 No VERSION
microsoft#27413 No VERSION
microsoft#27417 No VERSION
microsoft#27427 No VERSION
microsoft#27428 No VERSION
microsoft#27368 No VERSION
microsoft#27307 No VERSION
microsoft#27415 Fixed here.
microsoft#27371 Fixed here.
microsoft#27323 No VERSION
microsoft#27352 No VERSION
microsoft#27347 No VERSION
microsoft#27366 No VERSION
microsoft#27361 No VERSION
microsoft#27359 No VERSION
microsoft#27358 No VERSION
microsoft#27355 No VERSION
microsoft#27331 No VERSION
microsoft#24615 No VERSION
microsoft#27325 No VERSION
microsoft#24861 No VERSION
microsoft#27354 No VERSION
microsoft#27346 No VERSION
microsoft#27345 No VERSION
microsoft#27218 No VERSION
microsoft#27329 No VERSION
microsoft#27326 No VERSION
microsoft#27321 No VERSION
microsoft#27312 No VERSION
microsoft#27297 No VERSION
microsoft#27336 No VERSION
microsoft#27225 No VERSION
microsoft#27339 No VERSION
microsoft#27302 No VERSION
microsoft#27295 No VERSION
microsoft#27233 No VERSION
microsoft#27313 No VERSION
microsoft#27237 No VERSION
microsoft#27250 No VERSION
microsoft#27263 No VERSION
microsoft#27266 No VERSION
microsoft#27272 No VERSION
microsoft#27287 No VERSION
microsoft#27282 No VERSION
microsoft#27294 No VERSION
microsoft#27228 No VERSION
microsoft#27163 No VERSION
microsoft#26817 No VERSION
microsoft#27286 No VERSION
microsoft#27274 No VERSION
microsoft#27276 No VERSION
microsoft#27232 No VERSION
microsoft#27221 No VERSION
microsoft#27215 No VERSION
microsoft#27166 No VERSION
microsoft#27239 No VERSION
microsoft#27246 No VERSION
microsoft#27268 No VERSION
microsoft#27259 No VERSION
microsoft#27238 No VERSION
microsoft#27224 No VERSION
microsoft#27203 No VERSION
microsoft#27124 No VERSION
JavierMatosD pushed a commit that referenced this pull request Nov 8, 2022
* When @BillyONeal started being the on-call vcpkg maintainer on 2022-10-17, he started applying use of the "embedded VERSION" feature microsoft/vcpkg-tool#717 to PRs on merge.

@dg0yt points out that this use should be accompanied by a call to vcpkg_minimum_required, in https://github.com/microsoft/vcpkg/pull/27594/files#r1010641672

This is an audit of everything merged in that time and whether it needs to gain that.

#27561 No VERSION
#27525 No VERSION
#27554 Already has vcpkg_minimum_required
#27536 No VERSION
#27562 No VERSION
#24914 Fixed here
#27547 No VERSION
#27502 No VERSION
#27497 No VERSION
#27317 No VERSION
#27288 No VERSION
#27509 No VERSION
#27504 No VERSION
#27514 No VERSION
#27501 No VERSION
#27495 No VERSION
#27488 No VERSION
#27499 No VERSION
#27378 No VERSION
#27376 Fixed here
#27373 No VERSION
#27045 No VERSION
#27521 No VERSION
#27453 No VERSION
#27481 No VERSION
#27511 No VERSION
#27490 No VERSION
#27510 No VERSION
#27496 No VERSION
#27503 No VERSION
#27485 No VERSION
#27484 No VERSION
#27483 No VERSION
#27459 No VERSION
#27369 No VERSION
#27489 No VERSION
#26594 No VERSION
#27465 No VERSION
#27456 No VERSION
#27425 No VERSION
#27464 Fixed here
#27406 No VERSION
#27398 No VERSION
#27240 No VERSION
#27450 No VERSION
#27463 No VERSION
#27462 No VERSION
#27448 No VERSION
#27440 No VERSION
#27435 No VERSION
#27424 No VERSION
#27414 No VERSION
#27412 No VERSION
#27380 No VERSION
#27343 No VERSION
#27342 No VERSION
#27367 No VERSION
#27226 No VERSION
#27320 No VERSION
#26923 No VERSION
#27284 No VERSION
#27433 No VERSION
#27314 VERSION got *removed*
#27335 No VERSION
#27370 No VERSION
#27324 No VERSION
#27391 No VERSION
#27388 No VERSION
#27396 No VERSION
#27404 No VERSION
#27413 No VERSION
#27417 No VERSION
#27427 No VERSION
#27428 No VERSION
#27368 No VERSION
#27307 No VERSION
#27415 Fixed here.
#27371 Fixed here.
#27323 No VERSION
#27352 No VERSION
#27347 No VERSION
#27366 No VERSION
#27361 No VERSION
#27359 No VERSION
#27358 No VERSION
#27355 No VERSION
#27331 No VERSION
#24615 No VERSION
#27325 No VERSION
#24861 No VERSION
#27354 No VERSION
#27346 No VERSION
#27345 No VERSION
#27218 No VERSION
#27329 No VERSION
#27326 No VERSION
#27321 No VERSION
#27312 No VERSION
#27297 No VERSION
#27336 No VERSION
#27225 No VERSION
#27339 No VERSION
#27302 No VERSION
#27295 No VERSION
#27233 No VERSION
#27313 No VERSION
#27237 No VERSION
#27250 No VERSION
#27263 No VERSION
#27266 No VERSION
#27272 No VERSION
#27287 No VERSION
#27282 No VERSION
#27294 No VERSION
#27228 No VERSION
#27163 No VERSION
#26817 No VERSION
#27286 No VERSION
#27274 No VERSION
#27276 No VERSION
#27232 No VERSION
#27221 No VERSION
#27215 No VERSION
#27166 No VERSION
#27239 No VERSION
#27246 No VERSION
#27268 No VERSION
#27259 No VERSION
#27238 No VERSION
#27224 No VERSION
#27203 No VERSION
#27124 No VERSION

* Also add libcanberra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tensorflow-cc] build failure(BAZEL_VC/BAZEL_VS does not work when vs2019 and vs2022 exist on windows 11.)