Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libwebp] update to 1.2.3 #25959

Merged
merged 11 commits into from
Jul 28, 2022
Merged

Conversation

Neumann-A
Copy link
Contributor

No description provided.

github-actions[bot]
github-actions bot previously approved these changes Jul 24, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libwebp/vcpkg.json

Valid values for the license field can be found in the documentation

@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Jul 25, 2022
github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libwebp/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libwebp/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions[bot]
github-actions bot previously approved these changes Jul 25, 2022
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have modified or added at least one vcpkg.json where you should check the license field.

If you feel able to do so, please consider adding a "license" field to the following files:

  • ports/libwebp/vcpkg.json

Valid values for the license field can be found in the documentation

JonLiu1993
JonLiu1993 previously approved these changes Jul 26, 2022
@JonLiu1993 JonLiu1993 dismissed stale reviews from github-actions[bot] and themself via 222001e July 26, 2022 07:17
@JonLiu1993
Copy link
Member

All features are tested successfull in the following triplet:

  • x86-windows
  • x64-windows
  • x64-windows-static

@JonLiu1993
Copy link
Member

@Neumann-A, looks the ci test failed in x64-osx, this is error log, please take a look:

/Users/vagrant/Data/buildtrees/x264/install-x64-osx-dbg-err.log

install: mkdir /Users/vagrant/Data/packages/x264_x64-osx/Users/vagrant/Data: File exists
make: *** [install-lib-dev] Error 71
make: *** Waiting for unfinished jobs....

/Users/vagrant/Data/buildtrees/qtbase/install-x64-osx-dbg-out.log

clang: error: unable to execute command: Abort trap: 6
clang: error: clang frontend command failed due to signal (use -v to see invocation)
Apple clang version 13.0.0 (clang-1300.0.29.30)
Target: x86_64-apple-darwin21.2.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
clang: note: diagnostic msg: 

@Neumann-A
Copy link
Contributor Author

@JonLiu1993 cf2199b was green. and the only thing you did was to add a license. As such sich is probably a spurious CI issue after a lot of PR were merged into master. The first problem is probably because CI didn't clean correctly (or parallelism), the second issue is a compiler crash I can do little about.
What is the right action here? -> simply retry the CI run and hope for the best.

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Jul 28, 2022
@JavierMatosD JavierMatosD merged commit cf2e61b into microsoft:master Jul 28, 2022
@JavierMatosD
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants