-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minio-cpp] chore(version): updated to v0.1.0 #26145
Conversation
2228cb4
to
3e15792
Compare
87a313b
to
7541a3d
Compare
@harshavardhana, Can you take a look at this error first?
|
|
@harshavardhana If we don't want to build documentation, we could use https://github.com/minio/minio-cpp/blob/main/CMakeLists.txt#L115 |
3c026f8
to
681fc58
Compare
This is fixed @JonLiu1993 |
|
@harshavardhana, Can you successfully install window triplet locally?
|
@JonLiu1993 I do not have windows and perhaps I never will so there is no way for me to test it. This library would be Linux only for the most part and OSX (experimental) if we can get it to compile there. Also I have hard time finding builds logs for the failures that we would love to fix can you help where these are located? |
681fc58
to
bf6328b
Compare
|
Thanks for the update! |
Describe the pull request
What does your PR fix?
Updating minio-cpp version.
Which triplets are supported/not supported? Have you updated the [CI baseline]
all/No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/