-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[shiftmedia-libgcrypt] new port (Windows fork of Libgcrypt) #26364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/shiftmedia-libgcrypt/vcpkg.json b/ports/shiftmedia-libgcrypt/vcpkg.json
index 686fb4c..7a62c03 100644
--- a/ports/shiftmedia-libgcrypt/vcpkg.json
+++ b/ports/shiftmedia-libgcrypt/vcpkg.json
@@ -3,8 +3,8 @@
"version": "1.9.4",
"description": "An unofficial LibGCrypt with added custom native Visual Studio project build tools. LibGCrypt",
"homepage": "https://github.com/ShiftMediaProject/libgcrypt",
+ "supports": "windows",
"dependencies": [
"libgpg-error"
- ],
- "supports": "windows"
+ ]
}
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 5f83f03a1c7578e6ae04987916b34e018fb63964 -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 116ed08..851a17d 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -6604,6 +6604,10 @@
"baseline": "1.5.0",
"port-version": 3
},
+ "shiftmedia-libgcrypt": {
+ "baseline": "1.9.4",
+ "port-version": 0
+ },
"shiva": {
"baseline": "1.0",
"port-version": 5
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/shiftmedia-libgcrypt/vcpkg.json
Valid values for the license field can be found in the documentation
6a7d241
to
dd1c684
Compare
d9c11e5
to
2cb726d
Compare
8e77b9f
to
6bf0458
Compare
670e373
to
d813025
Compare
ff8c88a
to
edee4e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
88a60d1
to
c7b98b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one vcpkg.json where you should check the license
field.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/libgpg-error/vcpkg.json
Valid values for the license field can be found in the documentation
Thanks! |
Note: You probably could just have spent that time to make the native build work ;) The main drawback of using msbuild is that it does not currently support forwarding the toolchain. |
Well, I already spent ton of time on trying to get all these libs to build natively and there's always some odd platform that continues to fail (e.g. #20447). Meanwhile this was actually ready since a year ago, just needed some brush ups.
Yeah, am aware. Sooner or later the GnuPG toolkit gets native support in vcpkg, by then this allows me to work on other libraries I want to add ports for. |
Describe the pull request
This is a re-spin of the Windows work I did in #20433.
Similarly to #18029, it uses a SMP fork that adds native support for building the project. While it may be possible to build libgcrypt natively, it's not straightforward, so this may be a good interim solution to get a working set of GnuPG libraries across to vcpkg.
What does your PR fix?
libgpg-error
, disabled by Update vcpkg-tool to 2022-03-25 #23757libgcrypt
Which triplets are supported/not supported? Have you updated the CI baseline?
All of the Windows. Non-Windows ones are supported by the vanilla
libgcrypt
port.Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/