[vcpkg scripts] Crosscompiling fixes #26617

Neumann-A · 2022-08-31T18:06:40Z

No description provided.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

…imes...

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

…thers

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

error: checked-in files for vcpkg-cmake-get-vars have changed but the version was not updated
version: 2022-05-10#1
old SHA: b50ca3d20736304215fbd82c102d4552457255bb
new SHA: 5be9eb51bb1f156ca477a9f7b594ff756368d16b
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***

vicroms · 2022-10-03T04:51:10Z

/azp run

azure-pipelines · 2022-10-03T04:51:23Z

Azure Pipelines successfully started running 1 pipeline(s).

Neumann-A · 2022-10-04T17:41:38Z

Hmm don't know what happened to jemalloc on osx. Has been green in 184abe3 and only thing I did was merge with master. Looks like a concurrency issue?

dg0yt · 2022-10-04T18:11:33Z

Hmm don't know what happened to jemalloc on osx. Has been green in 184abe3 and only thing I did was merge with master. Looks like a concurrency issue?

install: mkdir /Users/vagrant/Data/packages/jemalloc_x64-osx/Users/vagrant/Data/installed: File exists

This is a typical symptom of concurrency issues during make install on osx. We need a DISABLE_PARALLEL_INSTALL and/or a reliable mkdir wrapper for osx.

JackBoosY · 2022-10-08T02:29:22Z

Should we wait for #27105 merge or just rerun the pipeline test?

…thers # Conflicts: # ports/vcpkg-cmake/vcpkg.json # versions/baseline.json # versions/v-/vcpkg-cmake.json

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 472e9f1a8bc5349ec21926fcfc6b2eb917cba01f -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f2cb3b7..5b1a5cb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7645,7 +7645,7 @@
       "port-version": 1
     },
     "vcpkg-cmake-get-vars": {
-      "baseline": "2022-05-10",
+      "baseline": "2022-09-04",
       "port-version": 1
     },
     "vcpkg-get-python-packages": {

dg0yt · 2023-05-03T06:07:10Z

scripts/cmake/vcpkg_configure_make.cmake

+    string(REGEX MATCHALL "( |^)(-D|-isysroot|--sysroot=|-isystem|-m?[Aa][Rr][Cc][Hh]|--target=|-target) ?[^ ]+" CPPFLAGS_${flag_suffix} "${VCPKG_DETECTED_CMAKE_C_FLAGS_${flag_suffix}}")
+    string(REGEX MATCHALL "( |^)(-D|-isysroot|--sysroot=|-isystem|-m?[Aa][Rr][Cc][Hh]|--target=|-target) ?[^ ]+" CXXPPFLAGS_${flag_suffix} "${VCPKG_DETECTED_CMAKE_CXX_FLAGS_${flag_suffix}}")


@Neumann-A Do you remember why you remove --target from ~~CFLAGS~~CFPFLAGS here?
It is explicitly injected into the flags by scripts/get_cmake_vars/CMakeLists.txt.
Removing this flag breaks android toolchains. (CMake selects clang for compiler, so --target=x86_64-none-linux-android21 etc. is needed to pick the right includes.) LDFLAGS still carries the option.

From building luajit (WIP):

ld: error: undefined symbol: _IO_putc >>> referenced by luajit.c:150 (/home/dg0yt/Projekte/vcpkg/vcpkg/buildtrees/luajit/x64-android-dbg/src/luajit.c:150) >>> luajit.o:(print_jit_status) >>> referenced by luajit.c:153 (/home/dg0yt/Projekte/vcpkg/vcpkg/buildtrees/luajit/x64-android-dbg/src/luajit.c:153) >>> luajit.o:(print_jit_status) >>> referenced by stdio.h:81 (/usr/lib/gcc/x86_64-linux-gnu/7.5.0/../../../../x86_64-linux-gnu/include/bits/stdio.h:81) >>> lib_base.o:(lj_cf_print) in archive libluajit.a >>> referenced 1 more times

some time after:

/<android-ndk-r25c>/toolchains/llvm/prebuilt/linux-x86_64/bin/clang -O2 -fomit-frame-pointer -Wall -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE -U_FORTIFY_SOURCE -DLUA_ROOT=\"/home/dg0yt/Projekte/vcpkg/vcpkg/installed/x64-android/debug\" -DLUA_MULTILIB=\"lib\" -fno-stack-protector -DLUAJIT_UNWIND_EXTERNAL -g -fdata-sections -ffunction-sections -funwind-tables -fstack-protector-strong -no-canonical-prefixes -Wformat -Werror=format-security -fPIC -fno-limit-debug-info -c -o luajit.o luajit.c

Ignore. I found the right track now.
TLDR: There is CFLAGS and there is CPPFLAGS, and I should use both...

Some people (meson) would argue all flags have to go into CC / CXX instead.

test osx stuff

cff0492

github-actions bot requested changes Aug 31, 2022

View reviewed changes

Adela0814 assigned LilyWangLL Sep 1, 2022

LilyWangLL changed the title ~~[scripts] A few osx fixes~~ [vcpkg scripts] A few osx fixes Sep 1, 2022

LilyWangLL added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Sep 1, 2022

Neumann-A added 3 commits September 1, 2022 15:38

deactivate most of ci

3f0bf20

get trace output

ce3fd60

add required flags to the linker flags

43553d9

github-actions bot requested changes Sep 1, 2022

View reviewed changes

Neumann-A added 2 commits September 1, 2022 22:33

also look for --sysroot

b8f6974

Link_args are always shared

c411a33

github-actions bot requested changes Sep 2, 2022

View reviewed changes

fix ar flags

5578e67

github-actions bot requested changes Sep 2, 2022

View reviewed changes

setup FOR_BUILD vars.

ac5c8f9

github-actions bot requested changes Sep 2, 2022

View reviewed changes

try tricking the build.... but man configure scripts are stupid somet…

98e8b82

…imes...

github-actions bot requested changes Sep 3, 2022

View reviewed changes

try 2

4b5f803

github-actions bot requested changes Sep 3, 2022

View reviewed changes

major meson rewrite

cf7adeb

github-actions bot requested changes Sep 3, 2022

View reviewed changes

fix duplicates

d905202

github-actions bot requested changes Sep 4, 2022

View reviewed changes

Neumann-A added 5 commits September 4, 2022 23:00

revert --trace-expand

8c6339f

update port version

6757d04

Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…

0bc3956

…thers

revert pipeline changes

332329f

v db

8b311a4

github-actions bot requested changes Sep 4, 2022

View reviewed changes

vicroms self-assigned this Sep 29, 2022

Merge branch 'microsoft:master' into fix_cpp_osx_and_others

f27f316

github-actions bot approved these changes Oct 1, 2022

View reviewed changes

Merge branch 'microsoft:master' into fix_cpp_osx_and_others

999c02e

github-actions bot previously approved these changes Oct 4, 2022

View reviewed changes

dg0yt mentioned this pull request Oct 5, 2022

[scripts|world rebuild] Retry 'make install' in non-parallel mode #27105

Merged

LilyWangLL removed the info:reviewed Pull Request changes follow basic guidelines label Oct 8, 2022

Neumann-A added 2 commits October 9, 2022 11:13

Merge remote-tracking branch 'upstream/master' into fix_cpp_osx_and_o…

0bf1edb

…thers # Conflicts: # ports/vcpkg-cmake/vcpkg.json # versions/baseline.json # versions/v-/vcpkg-cmake.json

v db

7292d87

Neumann-A dismissed stale reviews from github-actions[bot], LilyWangLL, and JackBoosY via 7292d87 October 9, 2022 09:13

github-actions bot requested changes Oct 9, 2022

View reviewed changes

Neumann-A added 2 commits October 9, 2022 11:15

remove port-version 1

6ae069e

v db

29d5b6d

github-actions bot approved these changes Oct 9, 2022

View reviewed changes

Neumann-A mentioned this pull request Oct 10, 2022

WIP: [x64-windows-intel] new Triplet: #15053

Closed

1 task

m-kuhn mentioned this pull request Oct 12, 2022

libiconv[core]:arm64-android build failure #27177

Closed

JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 13, 2022

vicroms merged commit d8e60ef into microsoft:master Oct 13, 2022

Neumann-A deleted the fix_cpp_osx_and_others branch October 13, 2022 16:52

m-kuhn mentioned this pull request Oct 15, 2022

[android] Add --host flags to triplets #27246

Merged

dg0yt mentioned this pull request Oct 21, 2022

[scripts] Fix meson for mingw #27380

Merged

dg0yt reviewed May 3, 2023

View reviewed changes

dg0yt mentioned this pull request May 3, 2023

[luajit] Use common build functions #30608

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vcpkg scripts] Crosscompiling fixes #26617

[vcpkg scripts] Crosscompiling fixes #26617

Neumann-A commented Aug 31, 2022

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

vicroms commented Oct 3, 2022

azure-pipelines bot commented Oct 3, 2022

Neumann-A commented Oct 4, 2022

dg0yt commented Oct 4, 2022

JackBoosY commented Oct 8, 2022

github-actions bot left a comment

dg0yt May 3, 2023 •

edited

Loading

dg0yt May 3, 2023

dg0yt May 3, 2023

Neumann-A May 3, 2023

		string(REGEX MATCHALL "( \|^)(-D\|-isysroot\|--sysroot=\|-isystem\|-m?[Aa][Rr][Cc][Hh]\|--target=\|-target) ?[^ ]+" CPPFLAGS_${flag_suffix} "${VCPKG_DETECTED_CMAKE_C_FLAGS_${flag_suffix}}")
		string(REGEX MATCHALL "( \|^)(-D\|-isysroot\|--sysroot=\|-isystem\|-m?[Aa][Rr][Cc][Hh]\|--target=\|-target) ?[^ ]+" CXXPPFLAGS_${flag_suffix} "${VCPKG_DETECTED_CMAKE_CXX_FLAGS_${flag_suffix}}")

[vcpkg scripts] Crosscompiling fixes #26617

[vcpkg scripts] Crosscompiling fixes #26617

Conversation

Neumann-A commented Aug 31, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

vicroms commented Oct 3, 2022

azure-pipelines bot commented Oct 3, 2022

Neumann-A commented Oct 4, 2022

dg0yt commented Oct 4, 2022

JackBoosY commented Oct 8, 2022

github-actions bot left a comment

Choose a reason for hiding this comment

dg0yt May 3, 2023 • edited Loading

Choose a reason for hiding this comment

dg0yt May 3, 2023

Choose a reason for hiding this comment

dg0yt May 3, 2023

Choose a reason for hiding this comment

Neumann-A May 3, 2023

Choose a reason for hiding this comment

dg0yt May 3, 2023 •

edited

Loading