-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stronk] Add new port #26740
[stronk] Add new port #26740
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/stronk/vcpkg.json b/ports/stronk/vcpkg.json
index 37cfb17..deec0ad 100644
--- a/ports/stronk/vcpkg.json
+++ b/ports/stronk/vcpkg.json
@@ -1,35 +1,34 @@
{
- "name": "stronk",
- "homepage": "https://github.com/twig-energy/stronk",
- "description": "An easy to customize, strong type library with built in support for unit-like behavior",
- "version-semver": "0.2.0",
- "license": "MIT",
- "dependencies": [
+ "name": "stronk",
+ "version-semver": "0.2.0",
+ "description": "An easy to customize, strong type library with built in support for unit-like behavior",
+ "homepage": "https://github.com/twig-energy/stronk",
+ "license": "MIT",
+ "builtin-baseline": "acc3bcf76b84ae5041c86ab55fe138ae7b8255c7",
+ "dependencies": [
+ {
+ "name": "boost-type-index",
+ "version>=": "1.78.0"
+ }
+ ],
+ "features": {
+ "abseil": {
+ "description": "Dependencies for abseil extension",
+ "dependencies": [
{
- "name": "boost-type-index",
- "version>=": "1.78.0"
- }
- ],
- "default-features": [],
- "features": {
- "fmt": {
- "description": "Dependencies for fmt extension",
- "dependencies": [
- {
- "name": "fmt",
- "version>=": "9.0.0"
- }
- ]
- },
- "abseil": {
- "description": "Dependencies for abseil extension",
- "dependencies": [
- {
- "name": "abseil",
- "version>=": "20211102.1"
- }
- ]
+ "name": "abseil",
+ "version>=": "20211102.1"
}
+ ]
},
- "builtin-baseline": "acc3bcf76b84ae5041c86ab55fe138ae7b8255c7"
+ "fmt": {
+ "description": "Dependencies for fmt extension",
+ "dependencies": [
+ {
+ "name": "fmt",
+ "version>=": "9.0.0"
+ }
+ ]
+ }
+ }
}
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for stronk have changed but the version was not updated
version: 0.2.0
old SHA: 3be2f1032c8ab0ac64f55c85bfd3ff86be78fe2c
new SHA: bc124b587321ac615d96a5f6c5b48869c6a50001
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/stronk/portfile.cmake
7e64d8a
to
ab2ed7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
All manifest files must be formatted
./vcpkg format-manifest ports/*/vcpkg.json
Diff
diff --git a/ports/stronk/vcpkg.json b/ports/stronk/vcpkg.json
index 37cfb17..deec0ad 100644
--- a/ports/stronk/vcpkg.json
+++ b/ports/stronk/vcpkg.json
@@ -1,35 +1,34 @@
{
- "name": "stronk",
- "homepage": "https://github.com/twig-energy/stronk",
- "description": "An easy to customize, strong type library with built in support for unit-like behavior",
- "version-semver": "0.2.0",
- "license": "MIT",
- "dependencies": [
+ "name": "stronk",
+ "version-semver": "0.2.0",
+ "description": "An easy to customize, strong type library with built in support for unit-like behavior",
+ "homepage": "https://github.com/twig-energy/stronk",
+ "license": "MIT",
+ "builtin-baseline": "acc3bcf76b84ae5041c86ab55fe138ae7b8255c7",
+ "dependencies": [
+ {
+ "name": "boost-type-index",
+ "version>=": "1.78.0"
+ }
+ ],
+ "features": {
+ "abseil": {
+ "description": "Dependencies for abseil extension",
+ "dependencies": [
{
- "name": "boost-type-index",
- "version>=": "1.78.0"
- }
- ],
- "default-features": [],
- "features": {
- "fmt": {
- "description": "Dependencies for fmt extension",
- "dependencies": [
- {
- "name": "fmt",
- "version>=": "9.0.0"
- }
- ]
- },
- "abseil": {
- "description": "Dependencies for abseil extension",
- "dependencies": [
- {
- "name": "abseil",
- "version>=": "20211102.1"
- }
- ]
+ "name": "abseil",
+ "version>=": "20211102.1"
}
+ ]
},
- "builtin-baseline": "acc3bcf76b84ae5041c86ab55fe138ae7b8255c7"
+ "fmt": {
+ "description": "Dependencies for fmt extension",
+ "dependencies": [
+ {
+ "name": "fmt",
+ "version>=": "9.0.0"
+ }
+ ]
+ }
+ }
}
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for stronk have changed but the version was not updated
version: 0.2.0
old SHA: 3be2f1032c8ab0ac64f55c85bfd3ff86be78fe2c
new SHA: bc124b587321ac615d96a5f6c5b48869c6a50001
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/stronk/portfile.cmake
I don't understand the last error from CI. I could use some pointers. |
ab2ed7b
to
2e5f66f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have modified or added at least one portfile where deprecated functions are used.
If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake
-> vcpkg_cmake_install
(from port vcpkg-cmake
)
vcpkg_build_cmake
-> vcpkg_cmake_build
(from port vcpkg-cmake
)
vcpkg_configure_cmake
-> vcpkg_cmake_configure
(Please remove the option PREFER_NINJA
) (from port vcpkg-cmake
)
vcpkg_fixup_cmake_targets
-> vcpkg_cmake_config_fixup
(from port vcpkg-cmake-config
)
In the ports that use the new function, you have to add the corresponding dependencies:
{
"name": "vcpkg-cmake",
"host": true
},
{
"name": "vcpkg-cmake-config",
"host": true
}
The following files are affected:
ports/stronk/portfile.cmake
Thanks for the review - I have fixed the issues specified in your comments |
All features are tested successfully in the following triplet:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json
or CONTROL
must be modified.
error: checked-in files for stronk have changed but the version was not updated
version: 0.2.0
old SHA: 05abc4825bdb2f676c1b3a9918b590957ef894fe
new SHA: b48ebf5e9c58bf7dc43b766bd7d96bf3ee757df5
Did you remember to update the version or port version?
Use --overwrite-version to bypass this check
***No files were updated***
df55925
df55925
to
3f3237f
Compare
3f3237f
to
ef91cf1
Compare
ef91cf1
to
0e52798
Compare
Describe the pull request
What does your PR fix?
It adds the stronk library to vcpkg (see https://github.com/twig-energy/stronk)
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes