Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draco] Update to 1.5.3 #27145

Merged
merged 1 commit into from
Oct 9, 2022
Merged

[draco] Update to 1.5.3 #27145

merged 1 commit into from
Oct 9, 2022

Conversation

Tradias
Copy link
Contributor

@Tradias Tradias commented Oct 8, 2022

@Tradias Tradias mentioned this pull request Oct 8, 2022
Closed
@LilyWangLL LilyWangLL added the category:port-update The issue is with a library, which is requesting update new revision label Oct 9, 2022
@FrankXie05
Copy link
Contributor

@MrROBUST Can you try the usage provided by this PR ？

@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Oct 9, 2022
@MrROBUST
Copy link

MrROBUST commented Oct 9, 2022

Hello @Tradias, thank you very much for the effort!
I can't find a complete example, but the minimal example from the issue now works as intended.

@vicroms vicroms merged commit cb423b3 into microsoft:master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FrankXie05 FrankXie05 FrankXie05 approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@FrankXie05 FrankXie05

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[draco] Can't link drakodec.lib with target_link_libraries, usage file missing
5 participants
@Tradias @FrankXie05 @MrROBUST @vicroms @LilyWangLL