Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vcpkg-cmake-config] Check for CMake package name problems #27568

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 31, 2022

  • What does your PR fix?

    Checks for CMake config installations which are not usable or wrongly handled by vcpkg tool's CMake usage heuristics.
    (The actual package name is in the filename, but both vcpkg_cmake_config_fixup and the tool look at the directory name.)
    Related: [vcpkg-tool] vcpkg install <pkg> gives wrong usage information #20190

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    all, no

  • Does your PR follow the maintainer guide?

    yes

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    I am still working on this PR.

    FTR I also do have preliminary work to improve the heuristics in vcpkg tool but it is not yet ready for a PR.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 253704407ae68efa37bf8f5b59b3e06dd40d3d3f -- versions
./vcpkg x-add-version --all
Diff
diff --git a/versions/baseline.json b/versions/baseline.json
index 2adee1d..d1970bd 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -7713,8 +7713,8 @@
       "port-version": 0
     },
     "vcpkg-cmake-config": {
-      "baseline": "2022-02-06",
-      "port-version": 1
+      "baseline": "2022-10-31",
+      "port-version": 0
     },
     "vcpkg-cmake-get-vars": {
       "baseline": "2022-09-04",
diff --git a/versions/v-/vcpkg-cmake-config.json b/versions/v-/vcpkg-cmake-config.json
index a354d87..0cf7c82 100644
--- a/versions/v-/vcpkg-cmake-config.json
+++ b/versions/v-/vcpkg-cmake-config.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "53e29f3419822c91bdfbf1ffcd8742bdad3e6d99",
+      "version-date": "2022-10-31",
+      "port-version": 0
+    },
     {
       "git-tree": "8d54cc4f487d51b655abec5f9c9c3f86ca83311f",
       "version-date": "2022-02-06",

@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 31, 2022
@Cheney-W Cheney-W self-assigned this Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants