Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC][docs] Add pattern matching docs #27686

Merged
merged 4 commits into from
Dec 19, 2022
Merged

[RFC][docs] Add pattern matching docs #27686

merged 4 commits into from
Dec 19, 2022

Conversation

vicroms
Copy link
Member

@vicroms vicroms commented Nov 7, 2022

@vicroms vicroms marked this pull request as draft November 7, 2022 01:03
github-actions[bot]
github-actions bot previously approved these changes Nov 7, 2022
View reviewed changes
@vicroms vicroms added category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. labels Nov 7, 2022
@vicroms vicroms mentioned this pull request Nov 7, 2022
Merged
6 tasks
@Cheney-W Cheney-W self-assigned this Nov 7, 2022
@vicroms vicroms force-pushed the docs/rfc/pattern-matching branch from f08405b to 15e06f1 Compare November 7, 2022 03:33
github-actions[bot]
github-actions bot previously approved these changes Nov 7, 2022
View reviewed changes
@vicroms vicroms changed the title [docs] Add pattern matching docs [RFC][docs] Add pattern matching docs Nov 7, 2022
@vicroms vicroms force-pushed the docs/rfc/pattern-matching branch from 15e06f1 to f74276f Compare November 7, 2022 06:57
github-actions[bot]
github-actions bot previously approved these changes Nov 7, 2022
View reviewed changes
github-actions[bot]
github-actions bot previously approved these changes Nov 9, 2022
View reviewed changes
@vicroms vicroms force-pushed the docs/rfc/pattern-matching branch from b704f8c to 3d25f2f Compare November 9, 2022 05:19
github-actions[bot]
github-actions bot previously approved these changes Nov 9, 2022
View reviewed changes
@vicroms vicroms mentioned this pull request Nov 12, 2022
Closed
4 tasks
@vicroms vicroms marked this pull request as ready for review December 14, 2022 00:04
AugP
AugP approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@AugP AugP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@vicroms vicroms added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Dec 14, 2022
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Dec 15, 2022
@JavierMatosD JavierMatosD merged commit a22a711 into microsoft:master Dec 19, 2022
ras0219-msft added a commit to ras0219-msft/vcpkg-docs that referenced this pull request Jan 13, 2023
@ras0219-msft
Transfer microsoft/vcpkg#27686
9216274
ras0219-msft added a commit to microsoft/vcpkg-docs that referenced this pull request Feb 6, 2023
@ras0219-msft
Transfer microsoft/vcpkg#27686 (#25)
aca856d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Neumann-A Neumann-A Neumann-A left review comments

@AugP AugP AugP approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vicroms @AugP @Neumann-A @Cheney-W @JavierMatosD