-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joltphysics] Add new port #27715
[joltphysics] Add new port #27715
Conversation
[joltphysics] Revert ci.baseline changes
Hi @RT222, thank you for the PR! You mentioned using the latest upstream commit instead of their latest release. However, we can't do this without upstreams approval. I went ahead and reached out to see if they approved or if they were willing to make an early release. Additionally, I noticed that this port doesn't provide any usage instructions. Under some conditions, To do so,
I will keep the info:reviewed label while I wait for upstream's response to make sure we don't drop this. |
ports/joltphysics/vcpkg.json
Outdated
"description": "A multi core friendly rigid body physics and collision detection library suitable for games and VR applications", | ||
"homepage": "https://github.com/jrouwe/JoltPhysics", | ||
"license": "MIT", | ||
"supports": "!(arm & uwp)", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The library should support ARM and UWP now.
I've created a new release of the library: v2.0.0. |
@RT222 It looks like @jrouwe was kind enough to do a release for us, so please update the port and version to the latest release. Additionally, the library now supports arm and uwp. We can delete them from the support clause. Finally, the usage text file is not technically required, so that wouldn't block this PR. That said, it would be very helpful. :) |
Thanks @JavierMatosD for the assistance, and thanks @jrouwe for your reactivity and for sharing with us this awesome library. There's still some issues to tackle before the port is ready :
|
By default it detects the ARM platform by:
Yes, Distribution is better if there are only 2 choices to make. |
Ok, I know what is going on. It's trying to compile the 32-bit ARM version instead of the 64-bit version.
works,
doesn't. Let me see if a 32-bit version can work. |
The latest version on 'master' should work now. Please let me know if it works for you too and then I'll create a release with it. |
I can confirm that it's working fine now, well done. :) |
Ok, I created release 2.0.1 |
4fd4216
I think it's ready to go. |
@RT222 Thanks again for the new port! |
I know this is not what's advocated for vcpkg, but for this port, I'm using the latest commit instead of the latest release version. The reason for that is that since the previous release, the CMakelist.txt file have been improved a lot, supports many more platforms and it was far easier to make a working and clean port from it.
What does your PR fix?
Add new port joltphysics : https://github.com/jrouwe/JoltPhysics
Which triplets are supported/not supported? Have you updated the [CI baseline]
All. No.
Does your PR follow the [maintainer guide]
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes