Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpaka] Fix Boost version constraints #27856

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

bernhardmgruber
Copy link
Contributor

When I proposed to include the alpaka library in #26812 I added version constraints for alpaka's Boost dependencies. However, it seems that the format for the version I entered was not correct. At least, if I use alpaka as a dependency in a project in manifest mode, I get the following error:

$ cmake -DCMAKE_TOOLCHAIN_FILE=~/dev/vcpkg/scripts/buildsystems/vcpkg.cmake ..
-- Running vcpkg install
Error: No version entry for boost-core at version 1.74. This may be fixed by updating vcpkg to the latest master via `git pull`.
Available versions:
    1.80.0#1
    1.80.0
    1.79.0
    1.78.0
    1.77.0
    1.76.0
    1.75.0
    1.74.0
    1.73.0
    1.72.0
    1.71.0
    1.70.0
    1.69.0
    1.68.0
    1.67.0
    1.66.0

See `vcpkg help versioning` for more information.

Notice that vcpkg says that there is no version 1.74 but the version 1.74.0 is available.

  • What does your PR fix?

It (tries to) fix the version constraints for Boost in the alpaka port. Please tell me if it is correct now!

Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

@BillyONeal BillyONeal merged commit 6d5b049 into microsoft:master Nov 16, 2022
@BillyONeal
Copy link
Member

Thanks for the fix!

@bernhardmgruber bernhardmgruber deleted the fix_alpaka branch November 17, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants