[tesseract] Update and fix feature training-tools build #29225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
LilyWangLL
added
category:port-feature
autoantwort
force-pushed
the
update-tesseract
branch
from
da8b4ad to
5751be8
Compare
dg0yt
reviewed
Jan 29, 2023
Comment on lines
-23
to
-25
| "cpu-independed": { | ||
| "description": "build on any cpu extension commands support" | ||
| }, |
There was a problem hiding this comment.
If the feature is removed instead of turning it into a no-op, vcpkg upgrade will break if the features is already installed.
There was a problem hiding this comment.
How about microsoft/vcpkg-tool#873
There was a problem hiding this comment.
I think it could be an extra option, so that features aren't uninstalled without notice.
There was a problem hiding this comment.
We could emit a warning
| target_link_libraries(unicharset_training | ||
| PUBLIC common_training org.sw.demo.unicode.icu.i18n) | ||
| else() | ||
| - if(${CMAKE_VERSION} VERSION_LESS "3.12.0") |
There was a problem hiding this comment.
I simply used the upstream merged patch
| target_include_directories(pango_training BEFORE | ||
| PUBLIC ${PANGO_INCLUDE_DIRS}) | ||
| target_compile_definitions(pango_training PUBLIC -DPANGO_ENABLE_ENGINE) | ||
| - if(${CMAKE_VERSION} VERSION_LESS "3.12.0") |
autoantwort
force-pushed
the
update-tesseract
branch
from
5751be8 to
c002a34
Compare
autoantwort
force-pushed
the
update-tesseract
branch
from
c002a34 to
08cbd83
Compare
Still hate that this is not the default ... |
autoantwort
force-pushed
the
update-tesseract
branch
from
08cbd83 to
e8fc720
Compare
|
Depends on #29266 |
LilyWangLL
added
the
depends:different-pr
autoantwort
force-pushed
the
update-tesseract
branch
from
e8fc720 to
bdee4fa
Compare
LilyWangLL
removed
the
depends:different-pr
LilyWangLL
approved these changes
Feb 3, 2023
|
Thanks for the update and feature fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./vcpkg x-add-version --alland committing the result.