Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miniply] add new port #29802

Merged
merged 1 commit into from
Apr 21, 2023
Merged

[miniply] add new port #29802

merged 1 commit into from
Apr 21, 2023

Conversation

fran6co
Copy link
Contributor

@fran6co fran6co commented Feb 23, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@Adela0814 Adela0814 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Feb 23, 2023
ports/miniply/CMakeLists.txt Outdated Show resolved Hide resolved
ports/miniply/vcpkg.json Show resolved Hide resolved
ports/miniply/portfile.cmake Outdated Show resolved Hide resolved
ports/miniply/CMakeLists.txt Outdated Show resolved Hide resolved
@Adela0814 Adela0814 changed the title miniply - add new port [miniply] add new port Feb 23, 2023
@fran6co fran6co requested a review from Adela0814 February 23, 2023 11:34
Adela0814
Adela0814 previously approved these changes Feb 24, 2023
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Feb 24, 2023
ports/miniply/fix-cmake.patch Outdated Show resolved Hide resolved
@JavierMatosD JavierMatosD added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Feb 24, 2023
ports/miniply/portfile.cmake Outdated Show resolved Hide resolved
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Mar 9, 2023
@dan-shaw
Copy link
Contributor

dan-shaw commented Mar 9, 2023

I don't think we can use the WINDOWS_EXPORT_ALL_SYMBOLS CMake variable as mentioned by the earlier review.

@dan-shaw dan-shaw added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Mar 9, 2023
@fran6co
Copy link
Contributor Author

fran6co commented Mar 9, 2023

I have removed it and it's static linking only now

@fran6co
Copy link
Contributor Author

fran6co commented Apr 3, 2023

ping @dan-shaw

ports/miniply/fix-cmake.patch Outdated Show resolved Hide resolved
@Adela0814 Adela0814 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 21, 2023
@BillyONeal BillyONeal merged commit 179c616 into microsoft:master Apr 21, 2023
@BillyONeal
Copy link
Member

Thanks for the new port!

SOURCE_PATH "${SOURCE_PATH}"
)
vcpkg_cmake_install()
vcpkg_cmake_config_fixup(CONFIG_PATH share/unofficial-miniply)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another broken CMake config!

@fran6co fran6co deleted the miniply branch April 22, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants