-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miniply] add new port #29802
Merged
Merged
[miniply] add new port #29802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adela0814
suggested changes
Feb 23, 2023
Adela0814
previously approved these changes
Feb 24, 2023
dg0yt
reviewed
Feb 24, 2023
JavierMatosD
previously requested changes
Feb 24, 2023
Adela0814
suggested changes
Mar 8, 2023
Adela0814
approved these changes
Mar 9, 2023
I don't think we can use the |
I have removed it and it's static linking only now |
ping @dan-shaw |
Adela0814
suggested changes
Apr 14, 2023
Adela0814
approved these changes
Apr 21, 2023
Thanks for the new port! |
dg0yt
reviewed
Apr 22, 2023
SOURCE_PATH "${SOURCE_PATH}" | ||
) | ||
vcpkg_cmake_install() | ||
vcpkg_cmake_config_fixup(CONFIG_PATH share/unofficial-miniply) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another broken CMake config!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxxvcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.