Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hdf5][seacas][vtk][vtk-m][paraview] remove mpi feature/ react to HDF5_WITH_PARALLEL #30667

Closed

Conversation

JavierMatosD
Copy link
Contributor

@JavierMatosD JavierMatosD commented Apr 4, 2023

Related to #22892 in response to #29724
This PR removes the mpi feature for seacas, vtk, vtk-m, and paraview. It enables parallelization if HDF5_WITH_PARALLEL is on. Notably, parmetis is now a dependency in seacas.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Neumann-A
Copy link
Contributor

Since when can we remove features? That breaks vcpkg upgrade as far as I am aware.

Comment on lines +31 to +35
{
"name": "parmetis",
"default-features": false,
"platform": "!osx"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So no seacas without MPI (which in return means no VTK without MPI)?
ParMETIS is an MPI-based parallel library that implements a variety of algorithms for partitioning unstructured graphs, meshes, and for computing fill-reducing orderings of sparse matrices.

Copy link
Contributor Author

@JavierMatosD JavierMatosD Apr 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should still be able to use seacas without MPI and have MPI enabled if hdf5[parallel] is installed. At least that's the goal here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no point in deactivating MPI if you pull in MPI via parmetis here.
You either want a full MPI build or you want a build without any MPI components at all.

Copy link
Contributor Author

@JavierMatosD JavierMatosD Apr 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You either want a full MPI build or you want a build without any MPI components at all.

@Neumann-A, is parmetis actually needed to enable MPI or is it just nice to have?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neumann-A, is parmetis actually needed to enable MPI or is it just nice to have?

I don't think it is a hard requirement but if you want it or not strongly depends on the problem size you have.

@JavierMatosD JavierMatosD marked this pull request as draft April 4, 2023 22:01
@JavierMatosD JavierMatosD changed the title [hdf5][seacas][vtk][vtk-m] remove mpi feature/ react to HDF5_WITH_PARALLEL [hdf5][seacas][vtk][vtk-m][paraview] remove mpi feature/ react to HDF5_WITH_PARALLEL Apr 4, 2023
@autoantwort
Copy link
Contributor

Since when can we remove features? That breaks vcpkg upgrade as far as I am aware.

Since microsoft/vcpkg-tool#873

@dg0yt
Copy link
Contributor

dg0yt commented Apr 5, 2023

Since when can we remove features? That breaks vcpkg upgrade as far as I am aware.

Since microsoft/vcpkg-tool#873

However, this only resolves the vcpkg upgrade part. Toggling versions in user manifests will remain hard if features are removed without transition period.

@Neumann-A
Copy link
Contributor

I think that the parallel feature in hdf5 needs a rename. Most people probably assume parallel means thread based parallelism or assume parallel=faster without knowing that it actually means something completely different.

@JavierMatosD JavierMatosD marked this pull request as ready for review April 5, 2023 17:35
@JavierMatosD JavierMatosD marked this pull request as draft April 5, 2023 17:49
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 6, 2023
@JavierMatosD
Copy link
Contributor Author

I no longer believe these changes are required, so I am closing this PR.

@JavierMatosD JavierMatosD deleted the hdf5_parallel_cleanup branch October 31, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants