-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hdf5][seacas][vtk][vtk-m][paraview] remove mpi feature/ react to HDF5_WITH_PARALLEL #30667
[hdf5][seacas][vtk][vtk-m][paraview] remove mpi feature/ react to HDF5_WITH_PARALLEL #30667
Conversation
# Conflicts: # ports/seacas/portfile.cmake
Since when can we remove features? That breaks |
{ | ||
"name": "parmetis", | ||
"default-features": false, | ||
"platform": "!osx" | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So no seacas without MPI (which in return means no VTK without MPI)?
ParMETIS is an MPI-based parallel library that implements a variety of algorithms for partitioning unstructured graphs, meshes, and for computing fill-reducing orderings of sparse matrices.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should still be able to use seacas without MPI and have MPI enabled if hdf5[parallel] is installed. At least that's the goal here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no point in deactivating MPI if you pull in MPI via parmetis
here.
You either want a full MPI build or you want a build without any MPI components at all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You either want a full MPI build or you want a build without any MPI components at all.
@Neumann-A, is parmetis
actually needed to enable MPI or is it just nice to have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Neumann-A, is parmetis actually needed to enable MPI or is it just nice to have?
I don't think it is a hard requirement but if you want it or not strongly depends on the problem size you have.
Since microsoft/vcpkg-tool#873 |
However, this only resolves the |
I think that the |
I no longer believe these changes are required, so I am closing this PR. |
Related to #22892 in response to #29724
This PR removes the
mpi
feature forseacas
,vtk
,vtk-m
, andparaview
. It enables parallelization ifHDF5_WITH_PARALLEL
is on. Notably,parmetis
is now a dependency inseacas
../vcpkg x-add-version --all
and committing the result.