Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zeromq] prevent using hosts libbsd when cross compiling #31007

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

jbbjarnason
Copy link
Contributor

@jbbjarnason jbbjarnason commented Apr 21, 2023

Solves the issue:
If the host has libbsd installed and you try to cross compile for aarch64 for example, the WITH_LIBBSD gets activated and fails to compile since it is non existing in aarch64 system root.

Default turning WITH_LIBBSD to OFF when vcpkg is configured to cross compile.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@jbbjarnason
Copy link
Contributor Author

jbbjarnason commented Apr 21, 2023

@microsoft-github-policy-service agree company="Skaginn 3X ehf."

@Cheney-W Cheney-W self-assigned this Apr 23, 2023
@Cheney-W Cheney-W changed the title zeromq prevent using hosts libbsd when cross compiling [zeromq] prevent using hosts libbsd when cross compiling Apr 23, 2023
@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines labels Apr 23, 2023
Cheney-W
Cheney-W previously approved these changes Apr 23, 2023
ports/zeromq/portfile.cmake Outdated Show resolved Hide resolved
@BillyONeal BillyONeal merged commit df92e33 into microsoft:master Apr 24, 2023
@BillyONeal
Copy link
Member

Thanks!

BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Apr 27, 2023
In microsoft#31104 I didn't notice that microsoft#31007 was accidentally reverted.
BillyONeal added a commit that referenced this pull request Apr 27, 2023
In #31104 I didn't notice that #31007 was accidentally reverted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants