-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zeromq] prevent using hosts libbsd when cross compiling #31007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@microsoft-github-policy-service agree company="Skaginn 3X ehf." |
Cheney-W
changed the title
zeromq prevent using hosts libbsd when cross compiling
[zeromq] prevent using hosts libbsd when cross compiling
Apr 23, 2023
Cheney-W
added
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
labels
Apr 23, 2023
Cheney-W
previously approved these changes
Apr 23, 2023
dg0yt
reviewed
Apr 23, 2023
…for shared/static objects
Cheney-W
approved these changes
Apr 24, 2023
Thanks! |
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Apr 27, 2023
In microsoft#31104 I didn't notice that microsoft#31007 was accidentally reverted.
BillyONeal
added a commit
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-bug
The issue is with a library, which is something the port should already support
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue:
If the host has libbsd installed and you try to cross compile for aarch64 for example, the WITH_LIBBSD gets activated and fails to compile since it is non existing in aarch64 system root.
Default turning WITH_LIBBSD to OFF when vcpkg is configured to cross compile.
./vcpkg x-add-version --all
and committing the result.