Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fluidsynth] Add pulseaudio feature for Linux #31138

Merged
merged 7 commits into from
May 1, 2023
Merged

[fluidsynth] Add pulseaudio feature for Linux #31138

merged 7 commits into from
May 1, 2023

Conversation

d10sfan
Copy link
Contributor

@d10sfan d10sfan commented Apr 26, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

This PR adds a pulseaudio feature for Linux for fluidsynth. This is so that fluidsynth can be built with pulseaudio support. Followed https://github.com/microsoft/vcpkg/pull/30679/files as an example for adding a similar feature.

@d10sfan
Copy link
Contributor Author

d10sfan commented Apr 26, 2023

@microsoft-github-policy-service agree

@d10sfan d10sfan marked this pull request as ready for review April 26, 2023 18:38
@LilyWangLL LilyWangLL self-assigned this Apr 27, 2023
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 27, 2023
LilyWangLL
LilyWangLL previously approved these changes Apr 28, 2023
View reviewed changes
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Apr 28, 2023
dg0yt
dg0yt suggested changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve https://learn.microsoft.com/en-us/vcpkg/contributing/pr-review-checklist#c000012.

@LilyWangLL LilyWangLL added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 28, 2023
@d10sfan
Copy link
Contributor Author

d10sfan commented Apr 28, 2023

Please resolve https://learn.microsoft.com/en-us/vcpkg/contributing/pr-review-checklist#c000012.

I've added a message related to pulseaudio if the pulseaudio feature is enabled.

dg0yt
dg0yt approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as the message is concerned.

@JavierMatosD JavierMatosD merged commit 8849a1a into microsoft:master May 1, 2023
@LilyWangLL LilyWangLL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels May 4, 2023
@d10sfan d10sfan deleted the fluidsynth-pulseaudio-feature branch August 10, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt approved these changes

@LilyWangLL LilyWangLL Awaiting requested review from LilyWangLL

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d10sfan @dg0yt @LilyWangLL @JavierMatosD