Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[portable-file-dialogs] Add new port #31482

Merged
merged 2 commits into from
May 22, 2023

Conversation

myd7349
Copy link
Contributor

@myd7349 myd7349 commented May 17, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 18, 2023
@JonLiu1993
Copy link
Member

@myd7349, Thanks for your PR, I see that the upstream code provides a CMakeLists file, why not install the CMakeLists file?

@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 JonLiu1993 marked this pull request as draft May 18, 2023 09:45
@myd7349
Copy link
Contributor Author

myd7349 commented May 18, 2023

@myd7349, Thanks for your PR, I see that the upstream code provides a CMakeLists file, why not install the CMakeLists file?

Hi @JonLiu1993 Thanks for your review.

Due to the lack of an "install" target in the CMakeLists.txt provided by the upstream repository, it is not possible to install the library using vcpkg_cmake_install. Currently, there is a PR that adds the install target for this library, but it has not been merged yet.

In light of this, considering that the library consists of a single header file, this approach has been adopted for installation.

@myd7349 myd7349 marked this pull request as ready for review May 18, 2023 10:24
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 19, 2023
@dan-shaw dan-shaw merged commit d672b68 into microsoft:master May 22, 2023
@myd7349 myd7349 deleted the portable-file-dialogs-init branch May 23, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants