Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5parts] Add new port #31544

Merged
merged 3 commits into from
May 31, 2023
Merged

[kf5parts] Add new port #31544

merged 3 commits into from
May 31, 2023

Conversation

leha-bot
Copy link
Contributor

@leha-bot leha-bot commented May 21, 2023

Fixes: #31538.

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@leha-bot leha-bot force-pushed the kf5-kparts branch 4 times, most recently from 7127553 to 2bf98d8 Compare May 21, 2023 21:43
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 22, 2023
@Cheney-W
Copy link
Contributor

CMake Error at D:/downloads/tools/cmake-3.25.1-windows/cmake-3.25.1-windows-i386/share/cmake-3.25/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Gettext (missing: GETTEXT_MSGMERGE_EXECUTABLE
  GETTEXT_MSGFMT_EXECUTABLE)

error log: https://dev.azure.com/vcpkg/public/_build/results?buildId=89693&view=artifacts&pathAsName=false&type=publishedArtifacts

@Cheney-W Cheney-W changed the title New package: kf5parts [kf5parts] Add new port May 22, 2023
ports/kf5parts/vcpkg.json Outdated Show resolved Hide resolved
@leha-bot leha-bot force-pushed the kf5-kparts branch 2 times, most recently from 0573f2a to fc3b70d Compare May 24, 2023 08:20
@leha-bot leha-bot marked this pull request as ready for review May 24, 2023 08:20
@Cheney-W Cheney-W marked this pull request as draft May 24, 2023 08:56
@Cheney-W
Copy link
Contributor

The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded.

leha-bot and others added 2 commits May 24, 2023 16:03
Co-authored-by: Cheney Wang <38240633+Cheney-W@users.noreply.github.com>
@leha-bot leha-bot marked this pull request as ready for review May 24, 2023 13:03
@leha-bot
Copy link
Contributor Author

Yes, addressed the review comments and updated the branch

@Cheney-W
Copy link
Contributor

    find_package(KF5Parts CONFIG REQUIRED)
    target_link_libraries(main PRIVATE KF5::Parts)

Usage test passed with x64-windows triplet.

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 25, 2023
@dan-shaw
Copy link
Contributor

Repology tells me the common package name for this is kparts, can we rename that? And most of them are still on major version 5.

@Cheney-W Cheney-W removed the info:reviewed Pull Request changes follow basic guidelines label May 26, 2023
@Cheney-W Cheney-W marked this pull request as draft May 26, 2023 06:50
@leha-bot
Copy link
Contributor Author

@dan-shaw , hello, I think we can, but there is a problem that another KDE Frameworks have port names like kf5<framework>. I think that it makes sense to rename it to kparts, but we also have to rename the rest frameworks; I think that it may be resolved like qt5 vs qt packages 🤔 ...

@leha-bot
Copy link
Contributor Author

So, Am I create new PR with kparts "meta-port" (like qt does with qt5)? If I will rename this port, then this is would be inconsistent with a rest of KDE Frameworks ports.

@leha-bot leha-bot marked this pull request as ready for review May 29, 2023 10:13
@Cheney-W
Copy link
Contributor

@dan-shaw What is your opinion on changing the ports of all 36 kf5 in vcpkg?

@leha-bot
Copy link
Contributor Author

(to clarify, I'm not against this ports renaming, I think that we may go futher faster if merge my PR and would make a new PR with bulk renaming (or adding "virtual port" like "qt" and "qt5" 😊 ))

@dan-shaw dan-shaw merged commit e527f17 into microsoft:master May 31, 2023
@leha-bot leha-bot deleted the kf5-kparts branch May 31, 2023 20:12
@leha-bot
Copy link
Contributor Author

Thank you!

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Port Request] KDE KParts (kf5parts)
4 participants