-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[recastnavigation] Update to 1.6.0 and use official CMakeLists #31551
[recastnavigation] Update to 1.6.0 and use official CMakeLists #31551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the GH repo and CMake config name, renaming the port to recastnavigation
should be seriously considered (and making the legacy port name simply depend on the new name).
In that case, the transitional config (see below) could be limited to the legacy port, and an additional transition warning can be printed when the legacy port is built.
Maybe not, upstream didn't complain about this. |
It is not about upstream. It is about users. |
Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags. |
Tested usage successfully by
|
Related: recastnavigation/recastnavigation#630