Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[recastnavigation] Update to 1.6.0 and use official CMakeLists #31551

Merged

Conversation

JackBoosY
Copy link
Contributor

Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the GH repo and CMake config name, renaming the port to recastnavigation should be seriously considered (and making the legacy port name simply depend on the new name).
In that case, the transitional config (see below) could be limited to the legacy port, and an additional transition warning can be printed when the legacy port is built.

ports/recast/portfile.cmake Outdated Show resolved Hide resolved
ports/recast/portfile.cmake Outdated Show resolved Hide resolved
@JackBoosY
Copy link
Contributor Author

Given the GH repo and CMake config name, renaming the port to recastnavigation should be seriously considered (and making the legacy port name simply depend on the new name).

Maybe not, upstream didn't complain about this.

@dg0yt
Copy link
Contributor

dg0yt commented May 22, 2023

Given the GH repo and CMake config name, renaming the port to recastnavigation should be seriously considered (and making the legacy port name simply depend on the new name).

Maybe not, upstream didn't complain about this.

It is not about upstream. It is about users.
FTR repology has 1 package for recast (vcpkg) and 26 packages for recastnavigation.

@JackBoosY JackBoosY changed the title [recast] Update to 1.6.0 and use official CMakeLists [recastnavigation] Update to 1.6.0 and use official CMakeLists May 22, 2023
@JonLiu1993 JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label May 22, 2023
ports/recast/vcpkg.json Outdated Show resolved Hide resolved
ports/recast/vcpkg.json Outdated Show resolved Hide resolved
versions/r-/recast.json Outdated Show resolved Hide resolved
ports/recast/usage Outdated Show resolved Hide resolved
@JonLiu1993
Copy link
Member

Note: I will be converting your PR to draft status. When you respond, please revert to "ready for review". That way, I can be aware that you've responded since you can't modify the tags.

@JonLiu1993 JonLiu1993 marked this pull request as draft May 23, 2023 01:45
@JackBoosY JackBoosY marked this pull request as ready for review May 23, 2023 05:52
@JonLiu1993
Copy link
Member

Tested usage successfully by recastnavigation:x64-windows:

Total install time: 692 us
recastnavigation provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(recastnavigation CONFIG REQUIRED)
    # note: 1 additional targets are not displayed.
    target_link_libraries(main PRIVATE RecastNavigation::Detour RecastNavigation::Recast RecastNavigation::DebugUtils RecastNavigation::DetourCrowd)

@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label May 23, 2023
@dan-shaw dan-shaw merged commit 2718aa5 into microsoft:master May 23, 2023
@JackBoosY JackBoosY deleted the dev/jack/update_recastnavigation_1.6.0 branch May 24, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants