Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lightningscanner] add new port #31631

Merged
merged 4 commits into from
May 30, 2023

Conversation

localcc
Copy link
Contributor

@localcc localcc commented May 25, 2023

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@localcc
Copy link
Contributor Author

localcc commented May 25, 2023

@microsoft-github-policy-service agree

@localcc localcc marked this pull request as draft May 25, 2023 13:53
@localcc localcc marked this pull request as ready for review May 25, 2023 14:37
@MonicaLiu0311 MonicaLiu0311 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 26, 2023
ports/lightningscanner/vcpkg.json Show resolved Hide resolved
ports/lightningscanner/portfile.cmake Outdated Show resolved Hide resolved
ports/lightningscanner/portfile.cmake Outdated Show resolved Hide resolved
versions/l-/lightningscanner.json Outdated Show resolved Hide resolved
ports/lightningscanner/portfile.cmake Show resolved Hide resolved
@MonicaLiu0311
Copy link
Contributor

The usage test passed (header files found):

The package lightningscanner is compatible with built-in CMake targets:

    find_package(LightningScanner REQUIRED)
    target_link_libraries(main PRIVATE LightningScanner::LightningScanner)

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label May 30, 2023
@dan-shaw dan-shaw merged commit ca2a346 into microsoft:master May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants