Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openvino]: new port #31671

Merged
merged 2 commits into from
Jun 17, 2023
Merged

[openvino]: new port #31671

merged 2 commits into from
Jun 17, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented May 28, 2023

Version 2023.0.0-plus is provided (it's based on current OpenVINO 2023.0.0 release plus extra fixes to support dependencies from vcpkg). This is why we were suggested to use version-date as a current versioning scheme. Later, It's supposed that once new is out, we will use typical version consisting of gidits.

Description: OpenVINO is Intel solution for inference of deep learning models. This can be useful for a lot of customers who already uses vcpkg as their dependency manager.

Note: OpenVINO core team will maintain this port and provide all updates when new versions are out.
In case of any issues, we are also ready to fix all bugs / answer all questions.

@ilya-lavrenov ilya-lavrenov force-pushed the openvino branch 7 times, most recently from 75e5fd4 to 9d6723d Compare May 28, 2023 22:06
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label May 29, 2023
@Cheney-W
Copy link
Contributor

Error logs:
https://dev.azure.com/vcpkg/public/_build/results?buildId=89960&view=artifacts&pathAsName=false&type=publishedArtifacts

system_conf.cpp.obj : error LNK2001: unresolved external symbol "public: static struct Xbyak::util::local::TypeT<0,0> const Xbyak::util::Cpu::NONE" (?NONE@Cpu@util@Xbyak@@2U?$TypeT@$0A@$0A@@local@23@B)
ngraph_referenced.lib(jit_generator.cpp.obj) : error LNK2001: unresolved external symbol "public: static struct Xbyak::util::local::TypeT<0,0> const Xbyak::util::Cpu::NONE" (?NONE@Cpu@util@Xbyak@@2U?$TypeT@$0A@$0A@@local@23@B)
...

@ilya-lavrenov ilya-lavrenov force-pushed the openvino branch 12 times, most recently from 52718d2 to c074aa4 Compare May 30, 2023 21:54
@ilya-lavrenov ilya-lavrenov force-pushed the openvino branch 5 times, most recently from 494a158 to 329c92f Compare May 31, 2023 05:59
@Cheney-W
Copy link
Contributor

Please remove the unused codes instead of comment them.

@ilya-lavrenov ilya-lavrenov force-pushed the openvino branch 5 times, most recently from 20877bd to 27bd522 Compare June 9, 2023 11:34
ports/openvino/vcpkg.json Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov marked this pull request as ready for review June 10, 2023 22:48
@ilya-lavrenov ilya-lavrenov requested review from dan-shaw and dg0yt June 10, 2023 22:48
Cheney-W
Cheney-W previously approved these changes Jun 12, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 12, 2023
ports/openvino/portfile.cmake Show resolved Hide resolved
ports/openvino/portfile.cmake Outdated Show resolved Hide resolved
@ilya-lavrenov ilya-lavrenov requested a review from dg0yt June 13, 2023 10:46
@Cheney-W
Copy link
Contributor

@vicroms Could you please take a look this PR?

@vicroms vicroms merged commit 287be77 into microsoft:master Jun 17, 2023
@ilya-lavrenov ilya-lavrenov deleted the openvino branch June 17, 2023 07:49
@autoantwort
Copy link
Contributor

It seems that this port has some problems:

openvino[core]:arm64-osx resulted in the unexpected state fail after 9.2 s 
openvino[core,auto]:arm64-osx resulted in the unexpected state fail after 8.4 s 
openvino[core,auto-batch]:arm64-osx resulted in the unexpected state fail after 8.2 s 
openvino[core,cpu]:arm64-osx resulted in the unexpected state fail after 17 s 
openvino[core,hetero]:arm64-osx resulted in the unexpected state fail after 8.6 s 
openvino[core,ir]:arm64-osx resulted in the unexpected state fail after 8.5 s 
openvino[core,pytorch]:arm64-osx resulted in the unexpected state fail after 8.1 s 
openvino[core,paddle]:arm64-osx resulted in the unexpected state fail after 16 s 
openvino[core,tensorflow-lite]:arm64-osx resulted in the unexpected state fail after 9.8 s 
openvino[core,onnx]:arm64-osx resulted in the unexpected state fail after 1.2 min 

@ilya-lavrenov
Copy link
Contributor Author

ilya-lavrenov commented Jun 18, 2023

It seems that this port has some problems:

openvino[core]:arm64-osx resulted in the unexpected state fail after 9.2 s 
openvino[core,auto]:arm64-osx resulted in the unexpected state fail after 8.4 s 
openvino[core,auto-batch]:arm64-osx resulted in the unexpected state fail after 8.2 s 
openvino[core,cpu]:arm64-osx resulted in the unexpected state fail after 17 s 
openvino[core,hetero]:arm64-osx resulted in the unexpected state fail after 8.6 s 
openvino[core,ir]:arm64-osx resulted in the unexpected state fail after 8.5 s 
openvino[core,pytorch]:arm64-osx resulted in the unexpected state fail after 8.1 s 
openvino[core,paddle]:arm64-osx resulted in the unexpected state fail after 16 s 
openvino[core,tensorflow-lite]:arm64-osx resulted in the unexpected state fail after 9.8 s 
openvino[core,onnx]:arm64-osx resulted in the unexpected state fail after 1.2 min 

Thank you for the report.
Could you please clarify where can I see more detailed logs? And what does "unexpected state fail" mean?

@autoantwort
Copy link
Contributor

I have uploaded the logs to https://cloud.hilton.rwth-aachen.de/index.php/s/bTPbP6XLHjcJqG9
unexpected state fail means that it is expected that the build works but it fails.
You should be able to reproduce the failures locally by running vcpkg x-set-installed openvino[core], vcpkg x-set-installed openvino[core,auto], ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants