Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libmicrohttpd] update and various fixes #31740

Merged
merged 11 commits into from
Jun 8, 2023
Merged

[libmicrohttpd] update and various fixes #31740

merged 11 commits into from
Jun 8, 2023

Conversation

Karlson2k
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Changes are in the individual commits for clarity.
They can be squashed into single commit

@Karlson2k
Copy link
Contributor Author

Karlson2k commented May 31, 2023 •
edited
Loading

@Karlson2k please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

It is strange that the whole repo is licensed under MIT/Expat license, while any contribution requires acceptance of separate license.
Ok, my contribution isn't that large so I @microsoft-github-policy-service agree

However, according to the repo license, any person have rights to use it, while according to Contribution License Agreement only Microsoft and persons who receive the code from Microsoft (directly or indirectly) have rights to use it.
Isn't it a legal issue?
How can I check that code, which I receive from 3rd party, is coming from Microsoft?
Do these two licenses conflict with each other?

Cheney-W
Cheney-W requested changes Jun 1, 2023
View reviewed changes
ports/libmicrohttpd/vcpkg.json Outdated Show resolved Hide resolved
@Cheney-W Cheney-W added the category:port-update The issue is with a library, which is requesting update new revision label Jun 1, 2023
@Cheney-W Cheney-W marked this pull request as draft June 1, 2023 07:58
@Cheney-W
Copy link
Contributor

Cheney-W commented Jun 1, 2023

Moving the PR to draft. Please set it to "ready for review" once changes have been applied.

@Cheney-W Cheney-W changed the title Libmicrohttpd update and various fixes [libmicrohttpd] update and various fixes Jun 1, 2023
@Cheney-W Cheney-W added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support labels Jun 1, 2023
@Karlson2k
Copy link
Contributor Author

@Cheney-W Do you want to squash all commits?
Otherwise I don't see how I can remove the port-version.
Even with squashed commits it needs at least "port-version": 2, correct?

@Cheney-W
Copy link
Contributor

Cheney-W commented Jun 2, 2023

Please remove "port-version": 1, from vcpkg.json because you have updated the "version": from 0.9.75 to 0.9.77.

@Cheney-W
Copy link
Contributor

Cheney-W commented Jun 2, 2023

If the port files are changed but the "version" is still 0.9.75, then the value of "port-version" should add 1. Obviously, you are not in this situation now.

@Karlson2k
Copy link
Contributor Author

Karlson2k commented Jun 2, 2023 •
edited
Loading

@Cheney-W Seems that you are looking at overrall changes by this PR.
Please check individual commits.
This PR has 10 commits with changes of vcpkg.json. Each commit is atomic, resulting vcpkg.json is fully functional after each commit.
First commit with version upgrade remove port-version, next commit add back port-version with value 1 and then aeach next commit bump port-version by one.
Let me know if you need to squash all of them into single commit.
With single commit port-version must be removed.

@Karlson2k Karlson2k marked this pull request as ready for review June 2, 2023 05:23
@dg0yt
Copy link
Contributor

dg0yt commented Jun 2, 2023

This PR has 10 commits with changes of vcpkg.json. Each commit is atomic, resulting vcpkg.json is fully functional after each commit.

The PR will be squased when merged.

@Karlson2k
Copy link
Contributor Author

@dg0yt OK, clear. I'll update it.

@Karlson2k
Copy link
Contributor Author

The PR has been updated.

@Karlson2k
[libmicrohttpd] Update to version 0.9.77
59775f9
@Karlson2k
[libmicrohttpd] Remove unneeded dependency
1e6caef 
Gettext is used by upstream only to build files for distribution.
Gettext is not used by the library itself.
@Karlson2k
[libmicrohttpd] Add ARM support
0936988 
The ARM is supported by upstream for a long time, VC support for ARM
was added in the version 0.9.77.
@Karlson2k
[libmicrohttpd] Use universal project for VC builds
0f31e46
@Karlson2k
[libmicrohttpd] Exclude wrong lib headers
cef992a
@Karlson2k
[libmicrohttpd] Support release/debug for non-VC builds
1df8e99
@Karlson2k
[libmicrohttpd] Add license
ebb46c7
@Karlson2k
[libmicrohttpd] Add "https" feature
7b6fa7b
@Karlson2k
[libmicrohttpd] Use right function for license file
4f12f95
@Karlson2k
[libmicrohttpd] Fix "supports"
0d907c0 
libmicrohttpd VC projects support only static library with static
runtime or dynamic library with dynamic runtime
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 8, 2023
@dan-shaw dan-shaw merged commit 431dcee into microsoft:master Jun 8, 2023
ybogo pushed a commit to ybogo/vcpkg that referenced this pull request Jun 9, 2023
@Karlson2k @ybogo
[libmicrohttpd] update and various fixes (microsoft#31740)
b1a534e 
* [libmicrohttpd] Update to version 0.9.77

* [libmicrohttpd] Remove unneeded dependency

Gettext is used by upstream only to build files for distribution.
Gettext is not used by the library itself.

* [libmicrohttpd] Add ARM support

The ARM is supported by upstream for a long time, VC support for ARM
was added in the version 0.9.77.

* [libmicrohttpd] Use universal project for VC builds

* [libmicrohttpd] Exclude wrong lib headers

* [libmicrohttpd] Support release/debug for non-VC builds

* [libmicrohttpd] Add license

* [libmicrohttpd] Add "https" feature

* [libmicrohttpd] Use right function for license file

* [libmicrohttpd] Fix "supports"

libmicrohttpd VC projects support only static library with static
runtime or dynamic library with dynamic runtime

* [libmicrohttpd] Update version database
@Karlson2k Karlson2k mentioned this pull request Jun 13, 2023
Closed
@Karlson2k Karlson2k deleted the libmicrohttpd_fixes_01 branch June 13, 2023 12:21
@Karlson2k Karlson2k mentioned this pull request Jun 16, 2023
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karlson2k @Cheney-W @dg0yt @dan-shaw