Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[winpcap/SDL1-mixer] Change the extension of the template MSBuild solution #31749

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Jun 1, 2023

Fixes #31652.

When opening the folder with the vcpkg submodule in Visual Studio, it shows the template solutions for the winpcap and sdl1-mixer ports in Solution Explorer. This PR changes the solution file's extension from .sln and .vcxproj to .sln.in and .vcxproj.in and renames it accordingly on install.
image

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@MonicaLiu0311 MonicaLiu0311 added info:internal This PR or Issue was filed by the vcpkg team. category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Jun 1, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review June 1, 2023 03:14
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Jun 1, 2023
@dan-shaw dan-shaw merged commit 0335503 into microsoft:master Jun 1, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/fix_sln branch June 2, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VS solutions/projects in the ports folder pollute VS targets list
3 participants