-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] update CMake to 3.27.1 #31931
Conversation
This already appeared in another issue recently, with CMake 3.26. They seem to have broken something around version arguments. |
@dg0yt If you want to chase it down feel free to do so https://gitlab.kitware.com/cmake/cmake/-/issues/24991#note_1375365 / https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7767 . I am probably just going to patch the few failing ports since that seems less work. |
@Neumann-A CMake 3.27 RC2 is out now for testing with, BTW the |
Hmm a lot of android failures. |
This one is new:
I am not able to reproduce that locally |
This is because with non-MinGW scenarios on Windows, the use of directx-headers and/or direcxtmath package is purely optional. If it can't find them, it just doesn't care and sticks with the Windows SDK headers. In the case of MinGW, however, the "Windows headers" there are, um, a mess. It has Direct3D 11 headers with some quirks, the DirectXMath headers exist but their contents is basically empty, and there's no DIrectX 12 headers. Therefore, in those cases it needs these packages but I wanted it to pass along the parameters from the including cmake. In the case of Linux, both packages are also required. |
@Neumann-A Please review microsoft/DirectXTex#380 |
@walbourn I used
to fix the problem since this controls the dependency explicitly in vcpkg. The problem is you can run into a situation where you build directxtex with directx-headers being found but when you consume them directx-headers is not found leading to the error observed. For the config you probably want something like:
instead since finding the deps is not going to be optional on Windows if the headers were found when building directxtex you will depend on the headers target. Moving the |
Ends up |
Configure log? Did you see the message from https://github.com/microsoft/DirectXTex/blob/4d9d7a8ceba6d6a121cd1aae160a0b856ef03d89/CMakeLists.txt#L206 ? |
IMO it is necessary: If the included files create imported targets, it shouldn't happen if a However I do agree that the |
Hmm should I update to 3.27.1 or just let this be merged ? |
Thanks very much for your contribution, updating to latest is best for users. |
Somebody want to fix the baseline regression of starlink-ast? For me that look like a optional dependency which is only found for release builds. |
The latest ci baseline does not appear starlink-ast:arm64-windows error. https://dev.azure.com/vcpkg/public/_build/results?buildId=92175&view=results |
Hm, Mismatched binaries is a recurring pattern with starlink-ast.
libast_grf_3.2.lib, libast_grf_5.6.lib, libast_pgplot.lib, libast_pgplot3d.lib were present for release in the successful vcpkg.ci run. |
I fail to spot significant differences in starlink config logs. I still feel nervous about cl : Command line warning D9002 : ignoring unknown option '-Xcompiler'
LINK : warning LNK4044: unrecognized option '/Xlinker'; ignored
-LINK : warning LNK4044: unrecognized option '/LD:/installed/arm64-windows/debug/lib'; ignored
+LINK : warning LNK4044: unrecognized option '/LD:/installed/arm64-windows/lib'; ignored but I have no interest to spend more time before the vcm fixes from #31228. |
@JonLiu1993: |
Why wouldn't the same issue apply to say directxmesh? |
@walbourn If it has the same logic it has the same problem. I only checked the previous ci failing ports. |
Upstream issue:
https://gitlab.kitware.com/cmake/cmake/-/issues/24991fixed in rc2https://gitlab.kitware.com/cmake/cmake/-/issues/25002There is also an issue update OpenSSL but that is not solved in 3.27.0
Note to self:
jmcnamara/libxlsxwriter#402fixed by another PRdcmtk regression is baseline(also another PR)Remove https://github.com/eclipse/paho.mqtt.c/blob/7db21329301b1f527c925dff789442db3ca3c1e7/src/CMakeLists.txt#L190-L191 from paho-mqtt; also unset any variable effecting openssl lookup in vcpkg-cmake-wrapper.cmakeCMake will also fix it in a newer release