Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating alpaca to latest release in github #31949

Merged
merged 1 commit into from
Jun 14, 2023
Merged

Conversation

sdavtaker
Copy link
Contributor

If this PR updates an existing port, please uncomment and fill out this checklist:

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@sdavtaker
Copy link
Contributor Author

@microsoft-github-policy-service agree

@jimwang118 jimwang118 added the category:port-update The issue is with a library, which is requesting update new revision label Jun 13, 2023
@@ -2,8 +2,8 @@
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO p-ranav/alpaca
REF v0.2.0
SHA512 0ac2c1c4f8e0534319bf852bac3852ee3674db7b1a9eda30462821ec4c9ddeeb6ceff09ef5f16eed9131af6c357a09f2cb909a12ea2f135ca7d496d90ff1865d
REF v0.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
REF v0.2.1
REF "v${VERSION}"

@jimwang118
Copy link
Contributor

Note: I will be converting your PR to draft status. The above suggested changes are only recommendations. If you are willing to adopt them, please click "ready for review" after making the modifications. If you do not wish to make any changes, please click "ready for review" directly. That way, I can be aware that you've responded since you can't modify the tags.

@sdavtaker
Copy link
Contributor Author

added the recommended change

@sdavtaker sdavtaker marked this pull request as ready for review June 13, 2023 15:20
@jimwang118
Copy link
Contributor

You need to re-run this command: ./vcpkg x-add-version {portname} --overwirte-version and then submit the result.

@sdavtaker
Copy link
Contributor Author

Rerun the version with overwrite this time.

@jimwang118
Copy link
Contributor

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Jun 14, 2023
@vicroms vicroms merged commit 7c4add3 into microsoft:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants