Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mathgl] URL Encode #31976

Merged
merged 1 commit into from
Jun 14, 2023
Merged

[mathgl] URL Encode #31976

merged 1 commit into from
Jun 14, 2023

Conversation

BillyONeal
Copy link
Member

Workaround on Ubuntu 22.04:

error: https://sourceforge.net/projects/mathgl/files/mathgl/mathgl 8.0/mathgl-8.0.1.tar.gz/download: curl failed to download with exit code 3
curl: (3) URL using bad/illegal format or missing URL

Workaround on Ubuntu 22.04:

error: https://sourceforge.net/projects/mathgl/files/mathgl/mathgl 8.0/mathgl-8.0.1.tar.gz/download: curl failed to download with exit code 3
curl: (3) URL using bad/illegal format or missing URL
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jun 13, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Jun 14, 2023
@vicroms vicroms merged commit a75e0a8 into microsoft:master Jun 14, 2023
@BillyONeal BillyONeal deleted the mathgl branch June 14, 2023 03:18
@dg0yt
Copy link
Contributor

dg0yt commented Jun 14, 2023

Will there be an issue to track a fix to this without workaround? Arguments should be literal, not URL-encoded.

@BillyONeal
Copy link
Member Author

Will there be an issue to track a fix to this without workaround? Arguments should be literal, not URL-encoded.

I didn't dig into the issue enough to determine who messed up here. Given that it occurred due to Ubuntu 22.04 I'm inclined to blame curl rather than us but not sure.

@dg0yt
Copy link
Contributor

dg0yt commented Jun 15, 2023

I didn't want to blame anybody, and I understand that there is a tight time frame for the current update.
I just want to point out that in my opinion vcpkg cmake functions shouldn't required regular parameter values to be urlencoded. No matter if the backend is curl or whatever.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants