Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[szip] Fix build on android #32914

Merged
merged 4 commits into from
Aug 4, 2023
Merged

[szip] Fix build on android #32914

merged 4 commits into from
Aug 4, 2023

Conversation

xiaozhuai
Copy link
Contributor

@xiaozhuai xiaozhuai commented Aug 3, 2023 •
edited
Loading

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Close #32845

Remove these lines in CI baseline

szip:arm-neon-android=fail
szip:arm64-android=fail
szip:x64-android=fail

and the downstream port hdf5 is also broken, so add these

hdf5:arm-neon-android=fail
hdf5:arm64-android=fail
hdf5:x64-android=fail

@xiaozhuai xiaozhuai mentioned this pull request Aug 3, 2023
Closed
@LilyWangLL LilyWangLL added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 3, 2023
@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 4, 2023
@JavierMatosD JavierMatosD merged commit 64d69a7 into microsoft:master Aug 4, 2023
15 checks passed
@xiaozhuai xiaozhuai deleted the dev-szip branch August 8, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LilyWangLL LilyWangLL LilyWangLL approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[szip] Build error
3 participants
@xiaozhuai @LilyWangLL @JavierMatosD