Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[murmurhash] Add support for arm #34059

Merged

Conversation

Pravila00
Copy link
Contributor

@Pravila00 Pravila00 commented Sep 27, 2023

Fixes #34056

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@Pravila00 Pravila00 changed the title Pabloro/add arm64 support murmurhash [murmurhash] Add support for arm Sep 27, 2023
@Pravila00 Pravila00 force-pushed the pabloro/add-arm64-support-murmurhash branch from 5553c2e to 63b6e04 Compare September 27, 2023 14:44
@Cheney-W Cheney-W added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Sep 28, 2023
@Cheney-W
Copy link
Contributor

@Pravila00 Thanks for your PR! Could you run ./vcpkg install murmurhash --triplet=arm64-linux successfully after this change?

@Cheney-W
Copy link
Contributor

I will be converting your PR to draft status. When you respond, please revert to "ready for review".

@Cheney-W Cheney-W marked this pull request as draft September 28, 2023 06:12
@Pravila00
Copy link
Contributor Author

Hi @Cheney-W , ./vcpkg install murmurhash --triplet=arm64-linux runs successfully.

./vcpkg install murmurhash --triplet=arm64-linux
Computing installation plan...
The following packages will be built and installed:
    murmurhash:arm64-linux -> 2016-01-09#7
  * vcpkg-cmake:x64-linux -> 2023-05-04
  * vcpkg-cmake-config:x64-linux -> 2022-02-06#1
Additional packages (*) will be modified to complete this operation.
Detecting compiler hash for triplet x64-linux...
Detecting compiler hash for triplet arm64-linux...
Restored 3 package(s) from /home/pabloro/.cache/vcpkg/archives in 378 ms. Use --debug to see more details.
Installing 1/3 vcpkg-cmake:x64-linux...
Elapsed time to handle vcpkg-cmake:x64-linux: 200 ms
Installing 2/3 vcpkg-cmake-config:x64-linux...
Elapsed time to handle vcpkg-cmake-config:x64-linux: 288 ms
Installing 3/3 murmurhash:arm64-linux...
Elapsed time to handle murmurhash:arm64-linux: 755 ms
Total install time: 1.2 s
murmurhash provides CMake targets:

  # this is heuristically generated, and may not be correct
  find_package(murmurhash CONFIG REQUIRED)
  target_link_libraries(main PRIVATE murmurhash::murmurhash)

@Pravila00 Pravila00 marked this pull request as ready for review September 28, 2023 07:33
@BillyONeal BillyONeal merged commit 4fb6f50 into microsoft:master Oct 3, 2023
@BillyONeal
Copy link
Member

Thanks!

@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Oct 7, 2023
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[murmurhash] build failure for linux arm64
4 participants