Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libconfig] Cleanup, fix libconfig++ cmake export #34646

Merged
merged 3 commits into from
Oct 23, 2023
Merged

[libconfig] Cleanup, fix libconfig++ cmake export #34646

merged 3 commits into from
Oct 23, 2023

Conversation

dg0yt
Copy link
Contributor

@dg0yt dg0yt commented Oct 21, 2023 •
edited
Loading

Fixes #30906.

Minimal patch here. Upstream variant: hyperrealm/libconfig#234

@dg0yt
Copy link
Contributor Author

dg0yt commented Oct 21, 2023

CC @HunterZ.

@Cheney-W Cheney-W added category:port-bug The issue is with a library, which is something the port should already support category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. labels Oct 23, 2023
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2023
@Cheney-W
Copy link
Contributor

Usage test passed with x64-windows triplet.

@JavierMatosD JavierMatosD merged commit bcc8b84 into microsoft:master Oct 23, 2023
@dg0yt dg0yt deleted the libconfig branch October 23, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cheney-W Cheney-W Cheney-W approved these changes

Assignees

@Cheney-W Cheney-W

Labels
category:code-cleanup This PR cleans up code, without fixing any existing bugs nor adding any features. category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libconfig] CMake support
3 participants
@dg0yt @Cheney-W @JavierMatosD