Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[abseil] Update to 20240116.1 #37461

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Conversation

jimwang118
Copy link
Contributor

Fixes #37439
Delete feature cxx17.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

x86-windows
x64-windows
x64-windows-static

@jimwang118 jimwang118 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Mar 15, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Mar 15, 2024

Why do you remove the feature?

@jimwang118
Copy link
Contributor Author

Why do you remove the feature?

Reviewing our maintenance guidelines does not recommend adding the C++ standard as a non-functional feature. https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md#do-not-use-features-to-control-alternatives-in-published-interfaces
Moreover, referring to RP, it is not recommended to add C++ standard features.

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Mar 15, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Mar 15, 2024

Yes, probably it wouldn't be added today.
IIRC in the case of abseil, removal was discussed in the past And until now, the decision was to keep it.

  • Abseil does forward usage requirements.
  • Abseil is very much about adding polyfill for C++ version, and its configuration has impact on downstream builds.

I don't say it works perfectly. For precise control, it is probably necessary to customize the triplet file for the toolchain and ports of interest.

@jimwang118 jimwang118 marked this pull request as ready for review March 18, 2024 02:02
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Mar 18, 2024
@BillyONeal BillyONeal merged commit 2639f60 into microsoft:master Mar 18, 2024
16 checks passed
@BillyONeal
Copy link
Member

Thanks for the update!

@jimwang118 jimwang118 deleted the up-abseil branch May 15, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[abseil] update to 2024.01.16.1
4 participants