[reflectcpp] Add open-source library reflectcpp to vcpkg #38899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree company="Code17 GmbH" |
jimwang118
added
the
category:new-port
BillyONeal
previously requested changes
Jun 11, 2024
There was a problem hiding this comment.
This port vendors dependencies which causes it to conflict with libraries already available in vcpkg. Please declare these as dependencies and use the versions provided by the corresponding ports.
PS D:\vcpkg> .\vcpkg.exe install reflectcpp
Computing installation plan...
The following packages will be built and installed:
reflectcpp:x64-windows@0.10.0
Detecting compiler hash for triplet x64-windows...
Compiler found: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.40.33807/bin/Hostx64/x64/cl.exe
Restored 0 package(s) from C:\Users\bion\AppData\Local\vcpkg\archives in 84.6 us. Use --debug to see more details.
Installing 1/1 reflectcpp:x64-windows@0.10.0...
Building reflectcpp:x64-windows@0.10.0...
-- Using cached getml-reflect-cpp-v0.10.0.tar.gz.
-- Cleaning sources at D:/vcpkg/buildtrees/reflectcpp/src/v0.10.0-7d3f399a13.clean. Use --editable to skip cleaning for the packages you specify.
-- Extracting source D:/vcpkg-downloads/getml-reflect-cpp-v0.10.0.tar.gz
-- Using source at D:/vcpkg/buildtrees/reflectcpp/src/v0.10.0-7d3f399a13.clean
-- Configuring x64-windows
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Installing: D:/vcpkg/packages/reflectcpp_x64-windows/share/reflectcpp/copyright
-- Performing post-build validation
error: The following files are already installed in D:/vcpkg/installed/x64-windows and are in conflict with reflectcpp:x64-windows
Installed by ctre:x64-windows
include/ctre.hpp
Installed by yyjson:x64-windows
include/yyjson.h
Stored binaries in 1 destinations in 131 ms.
Elapsed time to handle reflectcpp:x64-windows: 6.7 
jimwang118
reviewed
Jun 11, 2024
dg0yt
reviewed
Jun 11, 2024
We'll do upstream changes via: getml/reflect-cpp#79 |
BillyONeal
added
the
depends:upstream-changes
Changed. Should be ready to review again. |
jimwang118
requested changes
Jun 19, 2024
jimwang118
previously approved these changes
Jul 4, 2024
Changes are upstreamed and integrated. |
|
@BillyONeal Do you have any other modification requests for this PR? |
Any news? |
BillyONeal
added
info:reviewed
|
Sorry I lost track of this. |
|
Closed and reopened to trigger a remerge/retest given that it's been a while |
BillyONeal
dismissed
their stale review
The problems I pointed out appear resolved
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_packagecalls are REQUIRED, are satisfied byvcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.