Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[osqp] Add new port #39629

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[osqp] Add new port #39629

wants to merge 2 commits into from

Conversation

ex-purple
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@ex-purple
Copy link
Contributor Author

I don't know what the problem is with Windows builds

@WangWeiLin-MV WangWeiLin-MV added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jul 2, 2024
@WangWeiLin-MV
Copy link
Contributor

Please check the logs page or download logs from here.

@ex-purple
Copy link
Contributor Author

Yes, I've already looked. It's not clear to me

@data-queue
Copy link
Contributor

It's also not immediately clear to me why this port is failing on Windows either, maybe we can do supports: !windows in the vcpkg.json to move this PR forward?

@dg0yt
Copy link
Contributor

dg0yt commented Jul 24, 2024

multiple rules generate out/osqp.lib

on Windows/MSVC

Guess: One rule for static lib, one rule for import lib.

And indeed, CMakeLists.txt wants you to set OSQP_BUILD_SHARED_LIB and OSQP_BUILD_STATIC_LIB.
https://github.com/osqp/osqp/blob/ff371613bef82e85fb431590343853846ff96203/CMakeLists.txt#L59-L60

And vcpkg wants this for all triplets.

@data-queue data-queue marked this pull request as draft July 24, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants