Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google-cloud-cpp] update to the latest release (v2.27.0) #40220

Merged

Conversation

dbolduc
Copy link
Contributor

@dbolduc dbolduc commented Aug 1, 2024

Tested on x64 Linux with:

for feature in "developerconnect" "privilegedaccessmanager" "experimental-bigquerycontrol"; do ./vcpkg remove google-cloud-cpp; ./vcpkg install "google-cloud-cpp[core,${feature}]" || break; done

and:

./vcpkg remove google-cloud-cpp && ./vcpkg install 'google-cloud-cpp[*]'

Removed Patches

Abseil C++17 patch

cc: @dllg who authored #21942

I tested with:

./vcpkg install abseil[cxx17]
./vcpkg install google-cloud-cpp

It seems fine to me.

Mocks / CMake 3.30 patch

cc: @alichnewsky, @teo-tsirpanis who worked on #39802

We fixed the support for CMake 3.30 upstream in: googleapis/google-cloud-cpp#14433

I tested locally with CMake 3.30.1 with:

./vcpkg remove google-cloud-cpp && ./vcpkg install 'google-cloud-cpp[iam,iap,compute,kms,monitoring,logging,opentelemetry,pubsub,speech,storage,storageinsights,storagetransfer,support,tasks,trace,translate]

I do not think the peculiar use of cmake_dependent_option() was the issue, so I removed the patch.


  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@dbolduc dbolduc marked this pull request as draft August 1, 2024 19:47
@dbolduc dbolduc marked this pull request as ready for review August 2, 2024 02:05
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Aug 2, 2024
@MonicaLiu0311
Copy link
Contributor

Except compute,channel,asset, other features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Aug 5, 2024
@data-queue data-queue merged commit 82ecd5f into microsoft:master Aug 6, 2024
16 checks passed
@dbolduc dbolduc deleted the google-cloud-cpp-update-to-2.27.0 branch August 9, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants