Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libsquish]: Fix config error on android ndk r27 #40263

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

bwrsandman
Copy link
Contributor

Fixes #40262

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@bwrsandman bwrsandman force-pushed the libsquish-android-ndk-r27 branch 2 times, most recently from fd130cb to 024705e Compare August 4, 2024 14:10
@bwrsandman
Copy link
Contributor Author

Setting -DCMAKE_POLICY_DEFAULT_CMP0057=NEW is not enough because the order of project and cmake_minimum_required needs to be inversed.

@dg0yt
Copy link
Contributor

dg0yt commented Aug 4, 2024

That's why I didn't add comment here ;-)

@JonLiu1993 JonLiu1993 self-assigned this Aug 5, 2024
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 5, 2024
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 7, 2024
@data-queue data-queue merged commit d087ce1 into microsoft:master Aug 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[libsquish] build failure on <any>-android with ndk 27
4 participants