[vcpkg_download_distfile] always display output for downloading

[konjac]

This is for refinement mentioned in #40810

In vcpkg_download_distfile.cmake, it always hides the output of package downloading via x-download unless a failure. This behavior is not so friendly for debugging scenarios which need output. For example, when I configured asset cache with an external tool, I want to know whether the cache is hit.

So I propose this change to always show that output.

Before the change

After the change

[konjac]

@FrankXie05 The pr build is failing but seems unrelated to my change. Could you help check or retry the build?

[FrankXie05]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[BillyONeal]

Would it be better instead to just not redirect output in the first place? (That is, remove OUTPUT_VARIABLE and ERROR_VARIABLE above entirely rather than reprinting it here?)

Should we get rid of the message call on line 239 now?

[konjac]

@BillyONeal Thanks for the suggestion.

I think line 239 is still necessary and we can enclose the output like this, which could be better.

Suggested change

	message("${output}")
	if((NOT vcpkg_download_distfile_QUIET) OR (NOT "${error_code}" EQUAL "0"))
	message("${output}")
	endif()

After such a change, the log output is displayed when vcpkg_download_distfile_QUIET is off or error code is not zero.

[BillyONeal]

After such a change, the log output is displayed when vcpkg_download_distfile_QUIET is off or error code is not zero.

Isn't the whole point of this change that we always want to display the output, even when the exit code is zero?

[BillyONeal]

The --debug on line 260 seems wrong.

[JavierMatosD]

Thank you @konjac for your contribution. I've chosen to close this PR in favor of #40945

[konjac]

Thank you @konjac for your contribution. I've chosen to close this PR in favor of #40945

I think it is very impolite to close my PR without any prior requests. And actually, your new PR is just a few changes based on my idea.