Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magma] Fix build for Windows with CUDA 12.6 #41097

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

rbsheth
Copy link
Contributor

@rbsheth rbsheth commented Sep 20, 2024

Fixes #40941

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • When updating the upstream version, the "port-version" is reset (removed from vcpkg.json).
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@rbsheth
Copy link
Contributor Author

rbsheth commented Sep 20, 2024

@microsoft-github-policy-service agree company="Texel"

@BillyONeal
Copy link
Member

BillyONeal commented Sep 20, 2024

Can you try submitting this change upstream (to magma)? We normally want to give them a chance to look, which also fixes more than just the vcpkg version :)

@jimwang118 jimwang118 added the category:port-bug The issue is with a library, which is something the port should already support label Sep 23, 2024
@rbsheth
Copy link
Contributor Author

rbsheth commented Sep 23, 2024

@BillyONeal Looks like they've already added a fix, but c/d/sgbtf2_kernels.cu are missing from the repo. https://github.com/icl-utk-edu/magma/blob/4cb0501d76e79b8529162559588876455fef778a/magmablas/zgbtf2_kernels.cu#L15

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Sep 24, 2024
@JavierMatosD JavierMatosD merged commit 92133e3 into microsoft:master Sep 24, 2024
16 checks passed
@rbsheth rbsheth deleted the fix_magma_windows branch October 9, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[magma] Build error on x64-windows
4 participants